Skip to content

Commit 2480275

Browse files
committed
Revert "feat(button): as prop"
This reverts commit bc63742.
1 parent 9e2762b commit 2480275

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

src/components/Button/Button.vue

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
<template>
22
<Tooltip :text="tooltip" :disabled="!tooltip?.length">
3-
<component
3+
<button
44
v-bind="$attrs"
5-
:is="as"
65
:class="buttonClasses"
76
@click="handleClick"
87
:disabled="isDisabled"
@@ -60,10 +59,9 @@
6059
:class="slotClasses"
6160
/>
6261
</slot>
63-
</component>
62+
</button>
6463
</Tooltip>
6564
</template>
66-
6765
<script lang="ts" setup>
6866
import { computed, useSlots, ref } from 'vue'
6967
import FeatherIcon from '../FeatherIcon.vue'
@@ -75,7 +73,6 @@ import Tooltip from '../Tooltip/Tooltip.vue'
7573
defineOptions({ inheritAttrs: false })
7674
7775
const props = withDefaults(defineProps<ButtonProps>(), {
78-
as: 'button',
7976
theme: 'gray',
8077
size: 'sm',
8178
variant: 'subtle',

src/components/Button/types.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@ type Size = 'sm' | 'md' | 'md' | 'lg' | 'xl' | '2xl'
66
type Variant = 'solid' | 'subtle' | 'outline' | 'ghost'
77

88
export interface ButtonProps {
9-
/** The element or component this should render as */
10-
as?: string
11-
129
/** Visual color theme of the button */
1310
theme?: Theme
1411

0 commit comments

Comments
 (0)