fix: use supported wkhtmltox packages for Linux setup#4277
fix: use supported wkhtmltox packages for Linux setup#4277zay168 wants to merge 2 commits intofrappe:developfrom
Conversation
WalkthroughThe change modifies the wkhtmltopdf installation process and documentation. The install script now intelligently selects and installs distribution-specific prebuilt 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/helper/install.sh:
- Around line 47-50: The current early return when installing the .deb for
wkhtml_package gets bypassed by set -e because failures abort the script; change
the logic around the wkhtml_package block so the wget + apt install attempt is
tried but does not exit the script on failure—capture the commands' exit status
and only return when they succeed (e.g., run wget and sudo apt install for the
variable wkhtml_package, check their exit codes, and if both succeed then
return; otherwise continue to the tarball fallback). Ensure you reference the
wkhtml_package variable and the block that currently does wget -O
"/tmp/${wkhtml_package}" ... and sudo apt install ... "/tmp/${wkhtml_package}"
and replace the unconditional return with a conditional return based on success.
In `@README.md`:
- Around line 96-98: The fenced shell code block contains a leading shell prompt
character ('$') before the command 'bench start' which violates markdownlint
rule MD014; remove the leading '$' so the block contains just the raw command
(i.e., replace "$ bench start" with "bench start" in the fenced code block) to
satisfy the linter while keeping the command example intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d8fbdd8b-3b06-4d98-a8e6-c47de9cc63d6
📒 Files selected for processing (2)
.github/helper/install.shREADME.md
| ```sh | ||
| $ bench start | ||
| ``` |
There was a problem hiding this comment.
Remove shell prompts in command examples to satisfy markdownlint.
At Line [97], drop the leading $ in the fenced shell block (MD014) to keep docs lint-clean.
🧰 Tools
🪛 markdownlint-cli2 (0.22.0)
[warning] 97-97: Dollar signs used before commands without showing output
(MD014, commands-show-output)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` around lines 96 - 98, The fenced shell code block contains a
leading shell prompt character ('$') before the command 'bench start' which
violates markdownlint rule MD014; remove the leading '$' so the block contains
just the raw command (i.e., replace "$ bench start" with "bench start" in the
fenced code block) to satisfy the linter while keeping the command example
intact.
closes #4197
Summary
bookwormandjammypackages that depend onlibssl3Why
The current installation path around
wkhtmltox_file.debis misleading for modern Debian and Ubuntu derivatives. The maintained packaging release assets provide the correct filename pattern and avoid the legacylibssl1.1dependency that blocks manual installs on newer systems.Validation
jammyandbookwormassets exist inwkhtmltopdf/packagingrelease0.12.6.1-3.debcontrol files to confirm they depend onlibssl3and notlibssl1.1bash -n .github/helper/install.shwith Git Bashgit diff --checkSummary by CodeRabbit
New Features
Documentation