Migration fails on tabLoan Product ALTER TABLE — Truncated incorrect INTEGER value: ' ' #1120
Description
Information about bug
Body:
Lending version: v1.5.0
Frappe version: v15.94.1
Description:
Running bench --site migrate after upgrading to lending v1.5.0 fails during DocType migration for Loan Product.
Steps to reproduce:
Upgrade from lending v0.0.1 branch to v1.5.0
Run bench --site migrate
Error:
bench --site <site> migrate
Migrating erpdev.test.com
Updating DocTypes for frappe : [========================================] 100%
Updating DocTypes for erpnext : [========================================] 100%
Updating DocTypes for payments : [========================================] 100%
Updating DocTypes for hrms : [========================================] 100%
Updating DocTypes for lending : [== ] 5%Failed to alter schema using query: ALTER TABLE `tabLoan Product` MODIFY `maximum_loan_amount` decimal(21,9) not null default 0, MODIFY `penalty_interest_rate` decimal(21,9) not null default 0, MODIFY `rate_of_interest` decimal(21,9) not null default 0, MODIFY `cyclic_day_of_the_month` int(11) not null default 0, MODIFY `write_off_amount` decimal(21,9) not null default 0, MODIFY `excess_amount_acceptance_limit` decimal(21,9) not null default 0
There was an issue while migrating the DocType: Loan Product
Queued rebuilding of search index for <site>
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/home/frappe/frappe-bench/apps/frappe/frappe/utils/bench_helper.py", line 114, in <module>
main()
File "/home/frappe/frappe-bench/apps/frappe/frappe/utils/bench_helper.py", line 20, in main
click.Group(commands=commands)(prog_name="bench")
File "/home/frappe/frappe-bench/env/lib/python3.11/site-packages/click/core.py", line 1442, in __call__
return self.main(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/env/lib/python3.11/site-packages/click/core.py", line 1363, in main
rv = self.invoke(ctx)
^^^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/env/lib/python3.11/site-packages/click/core.py", line 1830, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/env/lib/python3.11/site-packages/click/core.py", line 1830, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/env/lib/python3.11/site-packages/click/core.py", line 1226, in invoke
return ctx.invoke(self.callback, **ctx.params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/env/lib/python3.11/site-packages/click/core.py", line 794, in invoke
return callback(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/env/lib/python3.11/site-packages/click/decorators.py", line 34, in new_func
return f(get_current_context(), *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/apps/frappe/frappe/commands/__init__.py", line 29, in _func
ret = f(frappe._dict(ctx.obj), *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/apps/frappe/frappe/commands/site.py", line 694, in migrate
).run(site=site)
^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/apps/frappe/frappe/migrate.py", line 193, in run
self.run_schema_updates()
File "/home/frappe/frappe-bench/apps/frappe/frappe/migrate.py", line 54, in wrapper
raise e
File "/home/frappe/frappe-bench/apps/frappe/frappe/migrate.py", line 46, in wrapper
ret = method(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/apps/frappe/frappe/migrate.py", line 123, in run_schema_updates
frappe.model.sync.sync_all()
File "/home/frappe/frappe-bench/apps/frappe/frappe/model/sync.py", line 44, in sync_all
sync_for(app, force, reset_permissions=reset_permissions)
File "/home/frappe/frappe-bench/apps/frappe/frappe/model/sync.py", line 112, in sync_for
import_file_by_path(
File "/home/frappe/frappe-bench/apps/frappe/frappe/modules/import_file.py", line 146, in import_file_by_path
import_doc(
File "/home/frappe/frappe-bench/apps/frappe/frappe/modules/import_file.py", line 239, in import_doc
doc.insert()
File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 334, in insert
self.run_post_save_methods()
File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1177, in run_post_save_methods
self.run_method("on_update")
File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1011, in run_method
out = Document.hook(fn)(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1371, in composer
return composed(self, method, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1353, in runner
add_to_return_value(self, fn(self, *args, **kwargs))
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1008, in fn
return method_object(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/apps/frappe/frappe/core/doctype/doctype/doctype.py", line 529, in on_update
raise e
File "/home/frappe/frappe-bench/apps/frappe/frappe/core/doctype/doctype/doctype.py", line 526, in on_update
frappe.db.updatedb(self.name, Meta(self))
File "/home/frappe/frappe-bench/apps/frappe/frappe/database/mariadb/database.py", line 468, in updatedb
db_table.sync()
File "/home/frappe/frappe-bench/apps/frappe/frappe/database/schema.py", line 50, in sync
self.alter()
File "/home/frappe/frappe-bench/apps/frappe/frappe/database/mariadb/schema.py", line 111, in alter
frappe.db.sql_ddl(query)
File "/home/frappe/frappe-bench/apps/frappe/frappe/database/database.py", line 412, in sql_ddl
self.sql(query, debug=debug)
File "/home/frappe/frappe-bench/apps/frappe/frappe/database/database.py", line 230, in sql
self._cursor.execute(query, values)
File "/home/frappe/frappe-bench/env/lib/python3.11/site-packages/pymysql/cursors.py", line 153, in execute
result = self._query(query)
^^^^^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/env/lib/python3.11/site-packages/pymysql/cursors.py", line 322, in _query
conn.query(q)
File "/home/frappe/frappe-bench/env/lib/python3.11/site-packages/pymysql/connections.py", line 563, in query
self._affected_rows = self._read_query_result(unbuffered=unbuffered)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/env/lib/python3.11/site-packages/pymysql/connections.py", line 825, in _read_query_result
result.read()
File "/home/frappe/frappe-bench/env/lib/python3.11/site-packages/pymysql/connections.py", line 1199, in read
first_packet = self.connection._read_packet()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/frappe/frappe-bench/env/lib/python3.11/site-packages/pymysql/connections.py", line 775, in _read_packet
packet.raise_for_error()
File "/home/frappe/frappe-bench/env/lib/python3.11/site-packages/pymysql/protocol.py", line 219, in raise_for_error
err.raise_mysql_exception(self._data)
File "/home/frappe/frappe-bench/env/lib/python3.11/site-packages/pymysql/err.py", line 150, in raise_mysql_exception
raise errorclass(errno, errval)
pymysql.err.OperationalError: (1292, "Truncated incorrect INTEGER value: ''")
Module
Loan Management
Version
erpnext version: v15.93.2
Lending version: v1.5.0
Frappe version: v15.94.1
hrms version: v15.54.2
Mint version: v1.1.1
Installation method
None
Relevant log output / Stack trace / Full Error Message.
Code of Conduct
- I agree to follow this project's Code of Conduct