Skip to content

Commit 0fce112

Browse files
Merge pull request #511 from frappe/fix/merge-duplicate-doc-key
fix: handle duplicate doc_key during merge
2 parents 0803b71 + e3723ac commit 0fce112

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

wiki/frappe_wiki/doctype/wiki_change_request/wiki_change_request.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1195,8 +1195,13 @@ def apply_merge_revision(space: Document, revision: Document) -> None:
11951195
if doc_key in key_to_name:
11961196
doc = frappe.get_doc("Wiki Document", key_to_name[doc_key])
11971197
else:
1198-
doc = frappe.new_doc("Wiki Document")
1199-
doc.doc_key = doc_key
1198+
# Check if a document with this doc_key exists outside the space's tree
1199+
existing_name = frappe.db.get_value("Wiki Document", {"doc_key": doc_key}, "name")
1200+
if existing_name:
1201+
doc = frappe.get_doc("Wiki Document", existing_name)
1202+
else:
1203+
doc = frappe.new_doc("Wiki Document")
1204+
doc.doc_key = doc_key
12001205

12011206
doc.title = item.get("title")
12021207
doc.slug = item.get("slug") or cleanup_page_name(item.get("title") or "")

0 commit comments

Comments
 (0)