Skip to content

Color assignment error in visualization.py::plot_search_distance_result #9

@knorthover

Description

@knorthover

tssearch/utils/visualization.py, function plot_search_distance_result() doesn't map colors correctly. In particular the minimum and maximum distance colors are incorrectly assigned to out of range values, making the plot misleading.

Line 114 in Scaling of distance for color lookup is incorrect:
d_idx = int((d - min_dist) * cmap.N / delta_dist) - 1 # INCORRECT
correct code shown below.
d_idx = int((d - min_dist) * (cmap.N -1) / delta_dist)

Sample values with incorrect and corrected scaling
tsssearch_plot_bug.txt

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions