fix

Signed-off-by: Frederic BIDON <[email protected]>

Author: fredbi

.github/workflows/markdown.yml

@@ -9,6 +9,9 @@ permissions:
   pull-requests: write
   contents: read
 
+env:
+  comment-title: Markdown linter
+
 jobs:
   markdown-changed:
     runs-on: ubuntu-latest
@@ -23,6 +26,8 @@ jobs:
       uses: tj-actions/changed-files@v45
       with:
         files: '**/*.md'
+    - name: Notify
+        echo "::notice::Detected some changed markdown files"
 
   lint-markdown:
     needs: markdown-changed
@@ -39,7 +44,6 @@ jobs:
       uses: actions/checkout@v4
 
     - name: Run markdown linter
-      if: steps.changed-markdown-files.outputs.any_changed == 'true'
       continue-on-error: true
       id: markdownlint
       uses: docker://avtodev/markdown-lint:v1
@@ -48,13 +52,25 @@ jobs:
         args: '${{ steps.changed-markdown-files.outputs.all_changed_files }}'
         output: ${{ env.lintreport }}
 
+    - name: Find previous PR comment
+      uses: peter-evans/find-comment@v3
+      id: findcomment
+      with:
+        issue-number:  ${{ github.event.pull_request.number }}
+        body-includes: ${{ env.comment-title }}
+        direction: last
+
     - name: Comment on success
       if: ${{ success() }}
       id: congrats
       uses: peter-evans/create-or-update-comment@v4
       with:
         issue-number: ${{ github.event.pull_request.number }}
+        comment-id: ${{ steps.findcomment.outputs.comment-id }}
+        reactions: hooray
+        reactions-edit-mode: replace
         body: |
+          ### ${{ env.comment-title }}
           Markdown looks good to me. Congrats!
 
     - name: Check lint report exists
@@ -63,13 +79,12 @@ jobs:
       run: |
         echo "proceed=true" >> $GITHUB_OUTPUT
         echo "report=$(cat ${{ env.lintreport }})" >> $GITHUB_OUTPUT
+        echo "::notice::Detected some linting issues with changed markdown"
 
   pr-comment:
     needs: lint-markdown
     if: ${{ needs.lint-markdown.proceed == 'true' && needs.lint-markdown.report != '' }}
     runs-on: ubuntu-latest
-    env:
-      comment-title: Markdown linting issues detected in modified files
 
     steps:
     - name: Format PR comment
@@ -80,9 +95,11 @@ jobs:
             text=${{ steps.conveyor.outputs.report }}
         template-text: |
             ### ${{ env.comment-title }}
-            This check is advisory and is not blocking. Please adopt a nice markdown style.
+            Some markdown linting issues were detected in modified .md files.
+
+            This check is advisory only and not blocking. Please adopt a nice markdown style.
 
-            Markdown rules formatting rules are documented [here](https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md).
+            Markdown formatting rules are documented [here](https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md).
             
             {{ text }}
 
@@ -91,12 +108,18 @@ jobs:
       id: findcomment
       with:
         issue-number:  ${{ github.event.pull_request.number }}
-        body-includes: ${{ steps.conveyor.outputs.report }}
+        body-includes: ${{ env.comment-title }}
         direction: last
 
     - name: Create or update PR comment
       uses: peter-evans/create-or-update-comment@v4
       with:
         issue-number: ${{ github.event.pull_request.number }}
         comment-id: ${{ steps.findcomment.outputs.comment-id }}
+        reactions: confused
+        reactions-edit-mode: replace
         body: ${{ steps.commentformatter.outputs.updated-text }}
+
+    - name: Notify
+        echo "::notice::Commented pull request ${{ github.event.pull_request.number }}"
+        echo "::debug::${{ step.commentformatter.outputs.updated-text }}"