Skip to content

Commit 48a5816

Browse files
committed
AC-663: Create phpcs static check for ClassesTest::testPhpCode
1 parent 19bb57b commit 48a5816

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

Magento2/Sniffs/Legacy/ClassReferencesInConfigurationFilesSniff.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ private function assertNonFactoryName(File $phpcsFile, array $elements)
7474
if (preg_match('/^([A-Z][a-z\d\\\\]+)+$/', $element->value) !== 1) {
7575
$phpcsFile->addError(
7676
self::ERROR_MESSAGE_CONFIG,
77-
$element->element->getLineNo() - 1,
77+
$element->lineNumber - 1,
7878
self::ERROR_CODE_CONFIG,
7979
);
8080
}
@@ -93,7 +93,7 @@ private function assertNonFactoryNameModule(File $phpcsFile, array $classes)
9393
if (preg_match('/^([A-Z][A-Za-z\d_]+)+$/', $element->value) !== 1) {
9494
$phpcsFile->addError(
9595
self::ERROR_MESSAGE_MODULE,
96-
$element->element->getLineNo() - 1,
96+
$element->lineNumber - 1,
9797
self::ERROR_CODE_MODULE,
9898
);
9999
}

Magento2/Sniffs/Legacy/ExtendedNode.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
namespace Magento2\Sniffs\Legacy;
88

9-
use DOMElement;
109
use SimpleXMLElement;
1110

1211
class ExtendedNode
@@ -17,9 +16,9 @@ class ExtendedNode
1716
public $value;
1817

1918
/**
20-
* @var DOMElement
19+
* @var int
2120
*/
22-
public $element;
21+
public $lineNumber;
2322

2423
/**
2524
* @param string $value
@@ -28,6 +27,6 @@ class ExtendedNode
2827
public function __construct(string $value, SimpleXMLElement $element)
2928
{
3029
$this->value = $value;
31-
$this->element = dom_import_simplexml($element);
30+
$this->lineNumber = dom_import_simplexml($element)->getLineNo();
3231
}
3332
}

0 commit comments

Comments
 (0)