Skip to content

Commit 04989d3

Browse files
committed
ACPT-752: Improve performance of processing segments validation
- Refactor and expand integration tests coverage;
1 parent 24a2c46 commit 04989d3

File tree

2 files changed

+34
-5
lines changed

2 files changed

+34
-5
lines changed

dev/tests/integration/testsuite/Magento/Newsletter/_files/three_subscribers.php

Lines changed: 26 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,36 @@
55
*/
66
declare(strict_types=1);
77

8-
use Magento\Newsletter\Model\SubscriberFactory;
8+
use Magento\Customer\Api\CustomerRepositoryInterface;
9+
use Magento\Newsletter\Model\Subscriber;
910
use Magento\TestFramework\Helper\Bootstrap;
1011
use Magento\TestFramework\Workaround\Override\Fixture\Resolver;
1112

1213
Resolver::getInstance()->requireDataFixture('Magento/Customer/_files/three_customers.php');
1314

1415
$objectManager = Bootstrap::getObjectManager();
15-
$subscriberFactory = $objectManager->get(SubscriberFactory::class);
16+
$customerRepository = $objectManager->create(CustomerRepositoryInterface::class);
1617

17-
$subscriberFactory->create()->subscribe('[email protected]');
18-
$subscriberFactory->create()->subscribe('[email protected]');
19-
$subscriberFactory->create()->subscribe('[email protected]');
18+
$customer1 = $customerRepository->get('[email protected]');
19+
$subscriber1 = $objectManager->create(Subscriber::class);
20+
$subscriber1->setStoreId($customer1->getStoreId())
21+
->setCustomerId($customer1->getId())
22+
->setSubscriberEmail('[email protected]')
23+
->setSubscriberStatus(Subscriber::STATUS_SUBSCRIBED)
24+
->save();
25+
26+
$customer2 = $customerRepository->get('[email protected]');
27+
$subscriber2 = $objectManager->create(Subscriber::class);
28+
$subscriber2->setStoreId($customer2->getStoreId())
29+
->setCustomerId($customer2->getId())
30+
->setSubscriberEmail('[email protected]')
31+
->setSubscriberStatus(Subscriber::STATUS_SUBSCRIBED)
32+
->save();
33+
34+
$customer3 = $customerRepository->get('[email protected]');
35+
$subscriber3 = $objectManager->create(Subscriber::class);
36+
$subscriber3->setStoreId($customer3->getStoreId())
37+
->setCustomerId($customer3->getId())
38+
->setSubscriberEmail('[email protected]')
39+
->setSubscriberStatus(Subscriber::STATUS_SUBSCRIBED)
40+
->save();

dev/tests/integration/testsuite/Magento/Newsletter/_files/three_subscribers_rollback.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,14 @@
55
*/
66
declare(strict_types=1);
77

8+
use Magento\TestFramework\Helper\Bootstrap;
89
use Magento\TestFramework\Workaround\Override\Fixture\Resolver;
910

1011
Resolver::getInstance()->requireDataFixture('Magento/Customer/_files/three_customers_rollback.php');
12+
13+
$objectManager = Bootstrap::getObjectManager();
14+
$subscriberCollection = $objectManager->get(\Magento\Newsletter\Model\ResourceModel\Subscriber\Collection::class);
15+
foreach ($subscriberCollection as $subscriber) {
16+
/** @var Magento\Newsletter\Model\Subscriber $subscriber */
17+
$subscriber->delete();
18+
}

0 commit comments

Comments
 (0)