Skip to content

Commit 2047d91

Browse files
Chhandak.BaruaChhandak.Barua
authored andcommitted
ACP2E-992 Allow Multiple Boxes for Shipping attribute is not saving value - Product Edit
1 parent 413a571 commit 2047d91

File tree

3 files changed

+9
-14
lines changed

3 files changed

+9
-14
lines changed

app/code/Magento/CatalogInventory/Test/Mftf/Section/AdminProductFormAdvancedInventorySection.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
<element name="enableQtyIncrementsOptions" type="select" selector="//*[@name='product[stock_data][enable_qty_increments]']//option[contains(@value, '{{var1}}')]" parameterized="true"/>
1414
<element name="enableQtyIncrementsUseConfigSettings" type="checkbox" selector="//input[@name='product[stock_data][use_config_enable_qty_inc]']"/>
1515
<element name="qtyUsesDecimals" type="select" selector="//*[@name='product[stock_data][is_qty_decimal]']"/>
16-
<element name="allowMultipleBoxesForShipping" type="select" selector="//*[@name='product[stock_data][stock_data][is_decimal_divided]']"/>
16+
<element name="allowMultipleBoxesForShipping" type="select" selector="//*[@name='product[stock_data][is_decimal_divided]']"/>
1717
<element name="qtyUsesDecimalsOptions" type="select" selector="//*[@name='product[stock_data][is_qty_decimal]']//option[contains(@value, '{{var1}}')]" parameterized="true"/>
18-
<element name="allowMultipleBoxesForShippingOptions" type="select" selector="//*[@name='product[stock_data][stock_data][is_decimal_divided]']//option[contains(@value, '{{var1}}')]" parameterized="true"/>
18+
<element name="allowMultipleBoxesForShippingOptions" type="select" selector="//*[@name='product[stock_data][is_decimal_divided]']//option[contains(@value, '{{var1}}')]" parameterized="true"/>
1919
<element name="qtyIncrements" type="input" selector="//input[@name='product[stock_data][qty_increments]']"/>
2020
<element name="qtyIncrementsUseConfigSettings" type="checkbox" selector="//input[@name='product[stock_data][use_config_qty_increments]']"/>
2121
<element name="doneButton" type="button" selector="//aside[contains(@class,'product_form_product_form_advanced_inventory_modal')]//button[contains(@data-role,'action')]" timeout="5"/>

app/code/Magento/CatalogInventory/Test/Mftf/Test/AdminAllowMultipleBoxesForShippingAttributeTest.xml

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,19 +41,16 @@
4141
<!--Step2. Open *Advanced Inventory* pop-up (Click on *Advanced Inventory* link). Set *Qty Uses Decimals* to *Yes*. Click on button *Done* -->
4242
<actionGroup ref="AdminClickOnAdvancedInventoryLinkActionGroup" stepKey="clickOnAdvancedInventoryLink"/>
4343
<scrollTo selector="{{AdminProductFormAdvancedInventorySection.qtyUsesDecimals}}" stepKey="scrollToQtyUsesDecimalsDropBox"/>
44-
<dontSeeElement selector="{{AdminProductFormAdvancedInventorySection.allowMultipleBoxesForShipping}}" stepKey="dontSeeAllowMultipleBoxesForShippin"/>
44+
<dontSeeElement selector="{{AdminProductFormAdvancedInventorySection.allowMultipleBoxesForShipping}}" stepKey="dontSeeAllowMultipleBoxesForShipping"/>
4545
<click selector="{{AdminProductFormAdvancedInventorySection.qtyUsesDecimalsOptions('1')}}" stepKey="chooseYesOnQtyUsesDecimalsDropBox"/>
46-
<seeElement selector="{{AdminProductFormAdvancedInventorySection.allowMultipleBoxesForShipping}}" stepKey="seeAllowMultipleBoxesForShippin"/>
46+
<seeElement selector="{{AdminProductFormAdvancedInventorySection.allowMultipleBoxesForShipping}}" stepKey="seeElementOfAllowMultipleBoxesForShipping"/>
4747
<click selector="{{AdminProductFormAdvancedInventorySection.allowMultipleBoxesForShippingOptions('1')}}" stepKey="chooseYesOnAllowMultipleBoxesForShippingDropBox"/>
4848
<actionGroup ref="AdminSubmitAdvancedInventoryFormActionGroup" stepKey="clickOnDoneButton"/>
49-
<!--Step3. Open *Advanced Pricing* pop-up (Click on *Advanced Pricing* link). Click on *Add* button. Fill *0.5* in *Quantity*-->
50-
<scrollTo selector="{{AdminProductFormSection.productName}}" stepKey="scrollToProductName"/>
51-
<click selector="{{AdminProductFormSection.advancedPricingLink}}" stepKey="clickOnAdvancedPricingLink1"/>
52-
<waitForElement selector="{{AdminProductFormAdvancedPricingSection.customerGroupPriceAddButton}}" stepKey="waitForAddButton"/>
53-
<click selector="{{AdminProductFormAdvancedPricingSection.customerGroupPriceAddButton}}" stepKey="clickOnCustomerGroupPriceAddButton"/>
54-
<fillField selector="{{AdminProductFormAdvancedPricingSection.productTierPriceQtyInput('0')}}" userInput="0.5" stepKey="fillProductTierPriceQty"/>
55-
<!--Step4. Close *Advanced Pricing* (Click on button *Done*). Save *prod1* (Click on button *Save*)-->
56-
<click selector="{{AdminProductFormAdvancedPricingSection.doneButton}}" stepKey="clickOnDoneButton2"/>
5749
<actionGroup ref="AdminProductFormSaveActionGroup" stepKey="clickOnSaveButton"/>
50+
<!--Step5. Open *Advanced Inventory* pop-up (Click on *Advanced Inventory* link). Verify *Qty Uses Decimals* is *Yes*. and *Allow Multiple Boxes For Shipping* is *Yes* -->
51+
<actionGroup ref="AdminClickOnAdvancedInventoryLinkActionGroup" stepKey="clickOnAdvancedInventoryLinkToOpen"/>
52+
<scrollTo selector="{{AdminProductFormAdvancedInventorySection.qtyUsesDecimals}}" stepKey="scrollToQtyUsesDecimalsDropBoxToVerify"/>
53+
<see selector="{{AdminProductFormAdvancedInventorySection.qtyUsesDecimals}}" userInput="Yes" stepKey="seeQtyUsesDecimals"/>
54+
<see selector="{{AdminProductFormAdvancedInventorySection.allowMultipleBoxesForShipping}}" userInput="Yes" stepKey="seeAllowMultipleBoxesForShipping"/>
5855
</test>
5956
</tests>

app/code/Magento/CatalogInventory/view/adminhtml/ui_component/product_form.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -358,8 +358,6 @@
358358
<container name="container_is_decimal_divided" component="Magento_Ui/js/form/components/group" sortOrder="700">
359359
<argument name="data" xsi:type="array">
360360
<item name="config" xsi:type="array">
361-
<item name="formElement" xsi:type="string">container</item>
362-
<item name="dataScope" xsi:type="string">stock_data</item>
363361
<item name="imports" xsi:type="array">
364362
<item name="visible" xsi:type="string">${$.provider}:data.product.stock_data.is_qty_decimal</item>
365363
</item>

0 commit comments

Comments
 (0)