Add Linq Sum() with ToFutureValue tests

Author: nkreipke

src/NHibernate.Test/Async/Futures/LinqToFutureValueFixture.cs

@@ -8,6 +8,7 @@
 //------------------------------------------------------------------------------
 
 
+using System;
 using System.Linq;
 using NHibernate.Linq;
 using NUnit.Framework;
@@ -45,13 +46,71 @@ public async Task CanExecuteToFutureValueCountWithPredicateAsync()
 			}
 		}
 
+		[Test(Description = "https://github.com/nhibernate/nhibernate-core/issues/1387")]
+		public async Task ToFutureValueWithSumReturnsResultAsync()
+		{
+			using (var s = OpenSession())
+			{
+				var personsSum = s.Query<Person>()
+					.Select(x => x.Id)
+					.ToFutureValue(x => x.Sum());
+
+				Assert.IsNotNull(personsSum);
+				Assert.NotZero(await (personsSum.GetValueAsync()));
+			}
+		}
+
+		[Test]
+		public void ToFutureValueWithSumOnEmptySetThrowsAsync()
+		{
+			using (var s = OpenSession())
+			{
+				var personsSum = s.Query<Person>()
+					.Where(x => false) // make this an empty set
+					.Select(x => x.Id)
+					.ToFutureValue(x => x.Sum());
+
+				Assert.That(() => personsSum.GetValueAsync(), Throws.InnerException.TypeOf<InvalidOperationException>().Or.InnerException.TypeOf<ArgumentNullException>());
+			}
+		}
+
+		[Test]
+		public async Task ToFutureValueWithNullableSumReturnsResultAsync()
+		{
+			using (var s = OpenSession())
+			{
+				var ageSum = s.Query<Person>()
+					.Select(x => x.Age)
+					.ToFutureValue(x => x.Sum());
+
+				Assert.IsNotNull(ageSum);
+				Assert.IsNotNull(await (ageSum.GetValueAsync()));
+				Assert.NotZero((await (ageSum.GetValueAsync())).Value);
+			}
+		}
+
+		[Test]
+		public async Task ToFutureValueWithNullableSumOnEmptySetReturnsNullAsync()
+		{
+			using (var s = OpenSession())
+			{
+				var ageSum = s.Query<Person>()
+					.Where(x => false) // make this an empty set
+					.Select(x => x.Age)
+					.ToFutureValue(x => x.Sum());
+
+				Assert.IsNotNull(ageSum);
+				Assert.IsNull(await (ageSum.GetValueAsync()));
+			}
+		}
+
 		protected override void OnSetUp()
 		{
 			using (var session = OpenSession())
 			using (var transaction = session.BeginTransaction())
 			{
-				session.Save(new Person {Name = "Test1"});
-				session.Save(new Person {Name = "Test2"});
+				session.Save(new Person {Name = "Test1", Age = 20});
+				session.Save(new Person {Name = "Test2", Age = 30});
 				session.Save(new Person {Name = "Test3"});
 				session.Save(new Person {Name = "Test4"});
 				transaction.Commit();

src/NHibernate.Test/Futures/LinqToFutureValueFixture.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Linq;
 using NHibernate.Linq;
 using NUnit.Framework;
@@ -34,13 +35,71 @@ public void CanExecuteToFutureValueCountWithPredicate()
 			}
 		}
 
+		[Test(Description = "https://github.com/nhibernate/nhibernate-core/issues/1387")]
+		public void ToFutureValueWithSumReturnsResult()
+		{
+			using (var s = OpenSession())
+			{
+				var personsSum = s.Query<Person>()
+					.Select(x => x.Id)
+					.ToFutureValue(x => x.Sum());
+
+				Assert.IsNotNull(personsSum);
+				Assert.NotZero(personsSum.Value);
+			}
+		}
+
+		[Test]
+		public void ToFutureValueWithSumOnEmptySetThrows()
+		{
+			using (var s = OpenSession())
+			{
+				var personsSum = s.Query<Person>()
+					.Where(x => false) // make this an empty set
+					.Select(x => x.Id)
+					.ToFutureValue(x => x.Sum());
+
+				Assert.That(() => personsSum.Value, Throws.InnerException.TypeOf<InvalidOperationException>().Or.InnerException.TypeOf<ArgumentNullException>());
+			}
+		}
+
+		[Test]
+		public void ToFutureValueWithNullableSumReturnsResult()
+		{
+			using (var s = OpenSession())
+			{
+				var ageSum = s.Query<Person>()
+					.Select(x => x.Age)
+					.ToFutureValue(x => x.Sum());
+
+				Assert.IsNotNull(ageSum);
+				Assert.IsNotNull(ageSum.Value);
+				Assert.NotZero(ageSum.Value.Value);
+			}
+		}
+
+		[Test]
+		public void ToFutureValueWithNullableSumOnEmptySetReturnsNull()
+		{
+			using (var s = OpenSession())
+			{
+				var ageSum = s.Query<Person>()
+					.Where(x => false) // make this an empty set
+					.Select(x => x.Age)
+					.ToFutureValue(x => x.Sum());
+
+				Assert.IsNotNull(ageSum);
+				Assert.IsNull(ageSum.Value);
+			}
+		}
+
 		protected override void OnSetUp()
 		{
 			using (var session = OpenSession())
 			using (var transaction = session.BeginTransaction())
 			{
-				session.Save(new Person {Name = "Test1"});
-				session.Save(new Person {Name = "Test2"});
+				session.Save(new Person {Name = "Test1", Age = 20});
+				session.Save(new Person {Name = "Test2", Age = 30});
 				session.Save(new Person {Name = "Test3"});
 				session.Save(new Person {Name = "Test4"});
 				transaction.Commit();

src/NHibernate.Test/Futures/Mappings.hbm.xml

@@ -8,6 +8,7 @@
 			<generator class="native"/>
 		</id>
     <property name="Name"/>
+    <property name="Age"/>
 		<many-to-one name="Parent" />
 		<list name="Children" cascade="all">
 			<key column="parent_id" />

src/NHibernate.Test/Futures/Person.cs

@@ -7,6 +7,7 @@ public class Person
 		private IList<Person> children = new List<Person>();
 		private IList<Person> friends = new List<Person>();
 		private int id;
+		private int? age;
 		private Person parent;
 
         public virtual string Name { get; set; }
@@ -34,5 +35,11 @@ public virtual int Id
 			get { return id; }
 			set { id = value; }
 		}
+
+		public virtual int? Age
+		{
+			get { return age; }
+			set { age = value; }
+		}
 	}
 }