Skip to content
This repository was archived by the owner on Sep 25, 2019. It is now read-only.
This repository was archived by the owner on Sep 25, 2019. It is now read-only.

Grid Column Gap challenge matches with a declaration outside of the .container rule #228

@joshalling

Description

@joshalling

The grid column gap challenge doesn't ensure that your declaration is within the .container rule. This means you can put the grid-column-gap declaration in a different rule and still pass the challenge.

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. add the following code below the .container rule
  div {
     grid-column-gap: 20px;
  }
  1. Click run and the test passes

This issue persists throughout a lot of the Grid challenges. I propose that we update the regex to prevent the test from passing if a closing curly brace is present between the .container selector and the grid-column-gap declaration.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions