Skip to content

Commit 5c99f2c

Browse files
committed
update Ember docs
* better organization of items (put classes at top level) * add both v3 and v2 docs
1 parent cc32a35 commit 5c99f2c

File tree

3 files changed

+23
-16
lines changed

3 files changed

+23
-16
lines changed

lib/docs/filters/ember/clean_html.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module Docs
22
class Ember
33
class CleanHtmlFilter < Filter
44
def call
5-
css('hr', '.edit-page', '.heading__link__edit', 'aside').remove
5+
css('hr', '.edit-page', '.heading__link__edit', 'aside', '.old-version-warning').remove
66

77
base_url.host.start_with?('api') ? api : guide
88

lib/docs/filters/ember/entries.rb

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,17 @@ def get_name
1717
def get_type
1818
if base_url.host.start_with?('api')
1919
name = self.name.remove(/ \(.*/)
20-
if name.start_with?('@') || name == 'rsvp'
21-
'Packages'
22-
elsif name == 'Function'
23-
'Functions'
20+
if name == 'Function'
21+
'3. Functions'
22+
elsif at_css('h1').content.start_with?('Package')
23+
'2. Packages'
2424
else
25-
'Classes'
25+
name = name.remove(' (methods)').remove(' (properties)').remove(' (events)')
26+
# Reference gets sorted to the top by default, need to have it with other classes so add a zero width space
27+
name == 'Reference' ? 'Reference​' : name
2628
end
2729
else
28-
'Guide'
30+
'1. Guide'
2931
end
3032
end
3133

lib/docs/scrapers/ember.rb

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,6 @@ class Ember < UrlScraper
77
self.name = 'Ember.js'
88
self.slug = 'ember'
99
self.type = 'ember'
10-
self.release = '3.25.0'
11-
self.base_urls = %w[
12-
https://guides.emberjs.com/v3.25.0/
13-
https://api.emberjs.com/ember/3.25/
14-
https://api.emberjs.com/ember-data/3.25/
15-
]
1610
self.links = {
1711
home: 'https://emberjs.com/',
1812
code: 'https://github.com/emberjs/ember.js'
@@ -54,12 +48,23 @@ class Ember < UrlScraper
5448

5549
options[:decode_and_clean_paths] = true # handle paths like @ember/application
5650

57-
def initial_urls
58-
%w(
51+
version '3' do
52+
self.release = '3.25.0'
53+
self.base_urls = %w[
5954
https://guides.emberjs.com/v3.25.0/
6055
https://api.emberjs.com/ember/3.25/
6156
https://api.emberjs.com/ember-data/3.25/
62-
)
57+
]
58+
end
59+
60+
version '2' do
61+
self.release = '2.18.0'
62+
self.base_urls = %w[
63+
https://guides.emberjs.com/v2.18.0/
64+
https://api.emberjs.com/ember/2.18/
65+
https://api.emberjs.com/ember-data/2.18/
66+
]
67+
options[:skip_patterns].push(/handlebars-basics$/)
6368
end
6469

6570
def get_latest_version(opts)

0 commit comments

Comments
 (0)