Improve get_latest_github_release

Author: jmerle

docs/scraper-reference.md

@@ -212,7 +212,7 @@ To make life easier, there are a few utility methods that you can use in `get_la
   Example: [lib/docs/scrapers/bower.rb](../lib/docs/scrapers/bower.rb)
 * `get_latest_github_release(owner, repo, opts)`
 
-  Returns the latest GitHub release of the given repository ([format](https://developer.github.com/v3/repos/releases/#get-the-latest-release)).
+  Returns the tag name of the latest GitHub release of the given repository. If the tag name is preceeded by a "v", the "v" will be removed.
 
   Example: [lib/docs/scrapers/jsdoc.rb](../lib/docs/scrapers/jsdoc.rb)
 * `get_github_tags(owner, repo, opts)`

lib/docs/core/doc.rb

@@ -249,7 +249,9 @@ def get_npm_version(package, opts)
     end
 
     def get_latest_github_release(owner, repo, opts)
-      fetch_json("https://api.github.com/repos/#{owner}/#{repo}/releases/latest", opts)
+      release = fetch_json("https://api.github.com/repos/#{owner}/#{repo}/releases/latest", opts)
+      tag_name = release['tag_name']
+      tag_name.start_with?('v') ? tag_name[1..-1] : tag_name
     end
 
     def get_github_tags(owner, repo, opts)

lib/docs/scrapers/homebrew.rb

@@ -21,7 +21,7 @@ class Homebrew < UrlScraper
     HTML
 
     def get_latest_version(opts)
-      get_latest_github_release('Homebrew', 'brew', opts)['name']
+      get_latest_github_release('Homebrew', 'brew', opts)
     end
   end
 end

lib/docs/scrapers/jasmine.rb

@@ -19,7 +19,7 @@ class Jasmine < UrlScraper
     HTML
 
     def get_latest_version(opts)
-      get_latest_github_release('jasmine', 'jasmine', opts)['name']
+      get_latest_github_release('jasmine', 'jasmine', opts)
     end
   end
 end

lib/docs/scrapers/jsdoc.rb

@@ -23,7 +23,7 @@ class Jsdoc < UrlScraper
     HTML
 
     def get_latest_version(opts)
-      get_latest_github_release('jsdoc3', 'jsdoc', opts)['tag_name']
+      get_latest_github_release('jsdoc3', 'jsdoc', opts)
     end
   end
 end

lib/docs/scrapers/julia.rb

@@ -51,7 +51,7 @@ class Julia < UrlScraper
     end
 
     def get_latest_version(opts)
-      get_latest_github_release('JuliaLang', 'julia', opts)['tag_name'][1..-1]
+      get_latest_github_release('JuliaLang', 'julia', opts)
     end
   end
 end

lib/docs/scrapers/knockout.rb

@@ -35,7 +35,7 @@ class Knockout < UrlScraper
     HTML
 
     def get_latest_version(opts)
-      get_latest_github_release('knockout', 'knockout', opts)['tag_name'][1..-1]
+      get_latest_github_release('knockout', 'knockout', opts)
     end
   end
 end

lib/docs/scrapers/kotlin.rb

@@ -30,7 +30,7 @@ class Kotlin < UrlScraper
     HTML
 
     def get_latest_version(opts)
-      get_latest_github_release('JetBrains', 'kotlin', opts)['tag_name'][1..-1]
+      get_latest_github_release('JetBrains', 'kotlin', opts)
     end
   end
 end

lib/docs/scrapers/laravel.rb

@@ -135,7 +135,7 @@ class Laravel < UrlScraper
     end
 
     def get_latest_version(opts)
-      get_latest_github_release('laravel', 'laravel', opts)['tag_name'][1..-1]
+      get_latest_github_release('laravel', 'laravel', opts)
     end
   end
 end

lib/docs/scrapers/matplotlib.rb

@@ -66,7 +66,7 @@ class Matplotlib < UrlScraper
     end
 
     def get_latest_version(opts)
-      get_latest_github_release('matplotlib', 'matplotlib', opts)['tag_name'][1..-1]
+      get_latest_github_release('matplotlib', 'matplotlib', opts)
     end
   end
 end