Skip to content

Commit ad8cd23

Browse files
committed
Update service worker to more accurately detect 'internal' url's
1 parent 3202837 commit ad8cd23

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

views/service-worker.js.erb

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,10 @@ self.addEventListener('fetch', event => {
4848

4949
<%# Attempt to return the index page from the cache if the user is visiting a url like devdocs.io/offline or devdocs.io/javascript/global_objects/array/find %>
5050
<%# The index page will make sure the correct documentation or a proper offline page is shown %>
51-
if (url.origin === location.origin && !url.pathname.replace(/~([0-9.])+/, '').includes('.')) {
51+
const pathname = url.pathname;
52+
const filename = pathname.substr(1 + pathname.lastIndexOf('/')).split(/\#|\?/g)[0];
53+
54+
if (url.origin === location.origin && !filename.includes('.')) {
5255
const cachedIndex = await caches.match('/');
5356
if (cachedIndex) return cachedIndex;
5457
}

0 commit comments

Comments
 (0)