fix: open external links in default browser from macOS PWA…

cpmsmith · cpmsmith · commit d426b47166e1 · 2025-02-20T23:50:56.000-05:00
…by using `window.open(url, "_blank", "noopener")` directly instead of a now-rarely-needed workaround. Fixes #2438
diff --git a/assets/javascripts/lib/util.js b/assets/javascripts/lib/util.js
@@ -457,13 +457,13 @@ $.noop = function () {};
 
 $.popup = function (value) {
   try {
+    window.open(value.href || value, "_blank", "noopener");
+  } catch (error) {
     const win = window.open();
     if (win.opener) {
       win.opener = null;
     }
     win.location = value.href || value;
-  } catch (error) {
-    window.open(value.href || value, "_blank");
   }
 };
 

Original file line number	Diff line number	Diff line change
`@@ -457,13 +457,13 @@ $.noop = function () {};`
`457`	`457`
`458`	`458`	`$.popup = function (value) {`
`459`	`459`	`try {`
	`460`	`+ window.open(value.href \|\| value, "_blank", "noopener");`
	`461`	`+ } catch (error) {`
`460`	`462`	`const win = window.open();`
`461`	`463`	`if (win.opener) {`
`462`	`464`	`win.opener = null;`
`463`	`465`	`}`
`464`	`466`	`win.location = value.href \|\| value;`
`465`		`- } catch (error) {`
`466`		`- window.open(value.href \|\| value, "_blank");`
`467`	`467`	`}`
`468`	`468`	`};`
`469`	`469`