parser: Add better error message for result assignment outside function

Author: dkl

changelog.txt

@@ -65,6 +65,7 @@ Version 1.01.0
 - Literal zeroes with [U]Byte or [U]Short type (or the 16bit Integer in -lang qb) can now be passed to pointer parameters of overloaded procedures (now it's possible to call Bsave() with 0 source buffer in -lang qb again -- it also was affected by this bug since FB 0.90)
 - #760: RETURN and FUNCTION= couldn't be used together in byref functions returning an UDT with constructor. This check is now only applied to functions returning byval.
 - #755: If no result is set in byref functions, the compiler will now show an error instead of a warning (because a byref function defaults to returning a null reference, most likely causing a crash at runtime)
+- #754: Better error message for function result assignments outside of the function
 
 
 Version 1.00.0 (former 0.91.0):

src/compiler/error.bas

@@ -396,7 +396,8 @@ declare function hMakeParamDesc _
 		@"the first parameter in a procedure may not be vararg", _
 		@"CONST used on constructor (not needed)", _
 		@"CONST used on destructor (not needed)", _
-		@"Byref function result not set" _
+		@"Byref function result not set", _
+		@"Function result assignment outside of the function" _
 	}
 
 

src/compiler/error.bi

@@ -318,6 +318,7 @@ enum FB_ERRMSG
 	FB_ERRMSG_CONSTCTOR
 	FB_ERRMSG_CONSTDTOR
 	FB_ERRMSG_NOBYREFFUNCTIONRESULT
+	FB_ERRMSG_RESULTASSIGNOUTSIDEFUNCTION
 
 	FB_ERRMSGS
 end enum

src/compiler/parser-proccall.bas

@@ -449,7 +449,7 @@ private function hProcSymbol _
 
 	'' check if name is valid (or if overloaded)
 	if( symbIsProcOverloadOf( parser.currproc, sym ) = FALSE ) then
-		errReport( FB_ERRMSG_ILLEGALOUTSIDEAPROC )
+		errReport( FB_ERRMSG_RESULTASSIGNOUTSIDEFUNCTION )
 		'' error recovery: skip stmt, return
 		hSkipStmt( )
 		return TRUE