suppress const warnings for internal array indexing

Author: jayrm

src/compiler/parser-expr-variable.bas

@@ -179,7 +179,7 @@ private function hFieldAccess _
 			'' Dynamic array field; access the descriptor field (same offset)
 			desc = symbGetArrayDescriptor( fld )
 			varexpr = astNewBOP( AST_OP_ADD, varexpr, offsetexpr )
-			varexpr = astNewCONV( typeAddrOf( symbGetFullType( desc ) ), symbGetSubtype( desc ), varexpr, AST_CONVOPT_DONTCHKPTR )
+			varexpr = astNewCONV( typeAddrOf( symbGetFullType( desc ) ), symbGetSubtype( desc ), varexpr, AST_CONVOPT_DONTCHKPTR or AST_CONVOPT_DONTWARNCONST )
 
 			tree = NULL
 			if( astHasSideFx( varexpr ) ) then
@@ -190,7 +190,7 @@ private function hFieldAccess _
 
 			'' *cptr( dtype ptr, var->descriptor.data + index )
 			varexpr = astNewBOP( AST_OP_ADD, varexpr, astNewCONSTi( symb.fbarray_data ) )
-			varexpr = astNewCONV( typeMultAddrOf( dtype, 2 ), subtype, varexpr, AST_CONVOPT_DONTCHKPTR )
+			varexpr = astNewCONV( typeMultAddrOf( dtype, 2 ), subtype, varexpr, AST_CONVOPT_DONTCHKPTR or AST_CONVOPT_DONTWARNCONST )
 			varexpr = astNewDEREF( varexpr )
 			varexpr = astNewBOP( AST_OP_ADD, varexpr, indexexpr )
 			varexpr = astNewDEREF( varexpr )

tests/warnings/const-discard.bas

@@ -1014,3 +1014,29 @@ scope
 	WARN(0)
 	memcpy( x + i, xc, 5 )
 end scope
+
+'' --------------------------------------------------------
+
+'' from https://www.freebasic.net/forum/viewtopic.php?p=254288#p254288
+
+#print "---- Array in Const UDT"
+
+type point
+	x as single
+	y as single
+end type
+
+type shape
+	points(any) as point
+end type
+
+sub const_udt_array( byref s as const shape )
+	WARN(0)
+	print lbound(s.points)
+	WARN(0)
+	print ubound(s.points)
+	WARN(0)
+	print @s.points(0)
+	WARN(0)
+	print s.points(0).x
+end sub

tests/warnings/r/dos/const-discard.txt

@@ -415,3 +415,8 @@ none expected
 none expected
 none expected
 none expected
+---- Array in Const UDT
+none expected
+none expected
+none expected
+none expected

tests/warnings/r/linux-x86/const-discard.txt

@@ -415,3 +415,8 @@ none expected
 none expected
 none expected
 none expected
+---- Array in Const UDT
+none expected
+none expected
+none expected
+none expected

tests/warnings/r/linux-x86_64/const-discard.txt

@@ -415,3 +415,8 @@ none expected
 none expected
 none expected
 none expected
+---- Array in Const UDT
+none expected
+none expected
+none expected
+none expected

tests/warnings/r/win32/const-discard.txt

@@ -415,3 +415,8 @@ none expected
 none expected
 none expected
 none expected
+---- Array in Const UDT
+none expected
+none expected
+none expected
+none expected

tests/warnings/r/win64/const-discard.txt

@@ -415,3 +415,8 @@ none expected
 none expected
 none expected
 none expected
+---- Array in Const UDT
+none expected
+none expected
+none expected
+none expected