Skip to content

Commit 654c870

Browse files
committed
fbc-debug: remove BINCL and EINCL STAB tags
- whitespace corrections - ctx.filename is never used, so ucase(*filename) is unnecessary - BINCL/EINCL appears to be intended to be used when the STAB type information is emitted for full headers. fbc doesn't do this, it only emits the type information for types that are actually used. In that sense, we are already emitting the least amount of type information possible. - therefore BINCL/EINCL tags are removed as they were previously used in a way that was never intended by the STAB format
1 parent 0f2a7c8 commit 654c870

File tree

1 file changed

+16
-20
lines changed

1 file changed

+16
-20
lines changed

src/compiler/edbg_stab.bas

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -214,11 +214,7 @@ sub edbgEmitHeader( byval filename as zstring ptr )
214214
ctx.typecnt = 1
215215
ctx.label = NULL
216216
ctx.incfile = NULL
217-
#If defined( __FB_WIN32__ ) or defined( __FB_DOS__ )
218-
ctx.filename = UCase(*filename)
219-
#Else
220-
ctx.filename = *filename
221-
#EndIf
217+
ctx.filename = *filename
222218

223219
'' emit source file name
224220
lname = *symbUniqueLabel( )
@@ -1021,22 +1017,22 @@ end sub
10211017
sub edbgInclude( byval incfile as zstring ptr )
10221018
dim as string lname
10231019

1024-
'' incfile is the new include file or main file name
1020+
'' incfile is the new include file or main file name
10251021

1026-
'' coming from _close incfile is null so no real need to change
1027-
If( incfile = NULL )Then
1028-
Exit Sub
1029-
EndIf
1022+
'' coming from _close incfile is null so no real need to change
1023+
If( incfile = NULL )Then
1024+
Exit Sub
1025+
EndIf
10301026

1031-
'' Already handling the correct name
1032-
if( incfile = ctx.incfile ) Then
1033-
exit sub
1034-
end If
1035-
1036-
emitSECTION( IR_SECTION_CODE, 0 )
1037-
lname = *symbUniqueLabel( )
1038-
hEmitSTABS( STAB_TYPE_SOL, incfile, 0, 0, lname )
1039-
hLABEL( lname )
1027+
'' Already handling the correct name
1028+
if( incfile = ctx.incfile ) Then
1029+
exit sub
1030+
end If
1031+
1032+
emitSECTION( IR_SECTION_CODE, 0 )
1033+
lname = *symbUniqueLabel( )
1034+
hEmitSTABS( STAB_TYPE_SOL, incfile, 0, 0, lname )
1035+
hLABEL( lname )
10401036

1041-
ctx.incfile = incfile
1037+
ctx.incfile = incfile
10421038
end sub

0 commit comments

Comments
 (0)