Skip to content

Commit 3c9a2f3

Browse files
committed
Ping: Make build reproducible
As recently fixed in sockstat (9934558), having tests/Makefile include files from the parent directory with SRCS= ../foo.c results in a race condition as the parent build and the tests build try to produce the same object file but contain different paths. Use .PATH to tell make to find sockstat.c in the parent directory but place the object file in the current object directory. Reviewed by: emaste, jrtc27, kevans MFC after: 3 days Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D53075
1 parent 16155cc commit 3c9a2f3

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

sbin/ping/tests/Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
ATF_TESTS_C+= in_cksum_test
2-
SRCS.in_cksum_test= in_cksum_test.c ../utils.c
2+
.PATH: ${.CURDIR:H}
3+
SRCS.in_cksum_test= in_cksum_test.c utils.c
34

45
PACKAGE= tests
56

0 commit comments

Comments
 (0)