Skip to content

Commit 75f2ae1

Browse files
Rick MacklemRick Macklem
authored andcommitted
Fix a lockorder reversal I introduced in r193436 when I moved the
mtx_destroy() of the pool mutex to after SVC_RELEASE(), because the pool mutex was still locked when soclose() was called by svc_dg_destroy(). To fix this, an mtx_unlock() was added where mtx_destroy() was before r193436. Reviewed by: jhb Tested by: pho Approved by: rwatson (mentor)
1 parent fe6ad77 commit 75f2ae1

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

sys/rpc/svc.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ svcpool_destroy(SVCPOOL *pool)
174174
svc_unreg(pool, s->sc_prog, s->sc_vers);
175175
mtx_lock(&pool->sp_lock);
176176
}
177+
mtx_unlock(&pool->sp_lock);
177178

178179
TAILQ_FOREACH_SAFE(xprt, &cleanup, xp_link, nxprt) {
179180
SVC_RELEASE(xprt);

0 commit comments

Comments
 (0)