Skip to content

Commit ef73953

Browse files
committed
gpioc: remove unnecessary bus_generic_* calls
gpioc never has any children, so there's no need to call these. Reviewed by: jhb Approved by: imp (mentor) Differential Revision: https://reviews.freebsd.org/D51933
1 parent 186100f commit ef73953

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

sys/dev/gpio/gpioc.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -621,7 +621,6 @@ static int
621621
gpioc_detach(device_t dev)
622622
{
623623
struct gpioc_softc *sc = device_get_softc(dev);
624-
int err;
625624

626625
if (sc->sc_ctl_dev)
627626
destroy_dev(sc->sc_ctl_dev);
@@ -632,9 +631,6 @@ gpioc_detach(device_t dev)
632631
}
633632
free(sc->sc_pin_intr, M_GPIOC);
634633

635-
if ((err = bus_generic_detach(dev)) != 0)
636-
return (err);
637-
638634
return (0);
639635
}
640636

@@ -1066,9 +1062,6 @@ static device_method_t gpioc_methods[] = {
10661062
DEVMETHOD(device_probe, gpioc_probe),
10671063
DEVMETHOD(device_attach, gpioc_attach),
10681064
DEVMETHOD(device_detach, gpioc_detach),
1069-
DEVMETHOD(device_shutdown, bus_generic_shutdown),
1070-
DEVMETHOD(device_suspend, bus_generic_suspend),
1071-
DEVMETHOD(device_resume, bus_generic_resume),
10721065

10731066
DEVMETHOD_END
10741067
};

0 commit comments

Comments
 (0)