lint: unit test

Author: freemindcore

easy/decorators.py

@@ -54,7 +54,7 @@ def docs_permission_required(
     member, redirecting to the login page if necessary.
     """
     actual_decorator = request_passes_test(
-        lambda r: ((r.user.is_active and r.user.is_staff)),
+        lambda r: (r.user.is_active and r.user.is_staff),
         login_url=login_url,
         redirect_field_name=redirect_field_name,
     )

easy/response.py

@@ -1,6 +1,7 @@
 import json
-from typing import Any, Dict, Union
+from typing import Any, Dict, List, Union
 
+from django.db.models import QuerySet
 from django.http.response import JsonResponse
 
 from easy.renderer.json import EasyJSONEncoder
@@ -17,7 +18,7 @@ class BaseApiResponse(JsonResponse):
 
     def __init__(
         self,
-        data: Union[Dict, str] = None,
+        data: Union[Dict, str, bool, List[Any], QuerySet] = None,
         code: int = None,
         message: str = None,
         **kwargs: Any

tests/conftest.py

@@ -1,9 +1,11 @@
 import copy
+from typing import Callable, Type, Union
 
 import pytest
 from django.contrib.auth import get_user_model
+from ninja_extra import ControllerBase, Router
 
-from easy.controller.base import CrudAPIController
+from easy import EasyAPI
 from easy.testing import EasyTestClient
 
 from .easy_app.auth import JWTAuthAsync, jwt_auth_async
@@ -23,7 +25,7 @@ def user(db) -> User:
 
 
 @pytest.fixture
-def easy_api_client(user) -> EasyTestClient:
+def easy_api_client(user) -> Callable:
     orig_func = copy.deepcopy(JWTAuthAsync.__call__)
 
     orig_has_perm_fuc = copy.deepcopy(user.has_perm)
@@ -41,11 +43,11 @@ async def mock_func(self, request):
     setattr(JWTAuthAsync, "__call__", mock_func)
 
     def create_client(
-        api: CrudAPIController,
+        api: Union[EasyAPI, Router, Type[ControllerBase]],
         is_staff: bool = False,
         is_superuser: bool = False,
         has_perm: bool = False,
-    ):
+    ) -> "EasyTestClient":
         setattr(user, "is_staff", is_staff)
         setattr(user, "is_superuser", is_superuser)
         if is_superuser:

tests/easy_app/controllers.py

@@ -22,7 +22,7 @@
 class AutoGenCrudAPIController(CrudAPIController):
     """
     For unit testings of the following auto generated APIs:
-        get/create/patch/delete/filter/filter_exclude
+        get/create/patch/delete
     """
 
     def __init__(self, service: EventService):
@@ -36,7 +36,7 @@ class Meta:
 @api_controller("unittest", permissions=[BaseApiPermission])
 class RecursiveAPIController(CrudAPIController):
     """
-    For unit testings of no recursive configuration
+    For unit testings of recursive configuration
     """
 
     def __init__(self, service: EventService):
@@ -52,7 +52,7 @@ class Meta:
 @api_controller("unittest", permissions=[BaseApiPermission])
 class InheritedRecursiveAPIController(AutoGenCrudAPIController):
     """
-    For unit testings of no recursive configuration
+    For unit testings of inherited recursive configuration
     """
 
     def __init__(self, service: EventService):
@@ -181,6 +181,10 @@ async def test_perm_admin_site(self, request, word: str):
 
 @api_controller("unittest", permissions=[AdminSitePermission])
 class AdminSitePermissionAPIController(CrudAPIController):
+    """
+    For unit testings of AdminSite permissions class
+    """
+
     def __init__(self, service: EventService):
         super().__init__(service)
         self.service = service
@@ -191,6 +195,10 @@ class Meta:
 
 @api_controller("unittest", permissions=[AdminSitePermission])
 class NoCrudAPIController(CrudAPIController):
+    """
+    For unit testings of no crud configuration
+    """
+
     def __init__(self, service: EventService):
         super().__init__(service)
         self.service = service
@@ -202,6 +210,10 @@ class Meta:
 
 @api_controller("unittest", permissions=[AdminSitePermission])
 class NoCrudInheritedAPIController(AdminSitePermissionAPIController):
+    """
+    For unit testings of no crud configuration (Inherited Class)
+    """
+
     def __init__(self, service: EventService):
         super().__init__(service)
         self.service = service

tests/easy_app/urls.py

@@ -1,21 +1,9 @@
 from django.contrib import admin
 from django.urls import path
 
-from easy import EasyAPI
-
-from .controllers import (
-    AutoGenCrudAPIController,
-    EasyCrudAPIController,
-    PermissionAPIController,
-)
-
-api = EasyAPI()
-api.register_controllers(EasyCrudAPIController)
-api.register_controllers(PermissionAPIController)
-api.register_controllers(AutoGenCrudAPIController)
-
+from .apis import api_unittest
 
 urlpatterns = [
     path("admin/", admin.site.urls),
-    path("api/", api.urls),
+    path("api/", api_unittest.urls),
 ]

tests/test_api_base_response.py

@@ -45,7 +45,7 @@ def test_base_api_edit():
     )
 
     with pytest.raises(KeyError):
-        orig_resp.json_data["detail"]
+        print(orig_resp.json_data["detail"])
 
     data = orig_resp.json_data