Skip to content

Commit 97e2afb

Browse files
committed
coverage: remove some pragma: no cover
1 parent fa08167 commit 97e2afb

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

easy/controller/base.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import logging
2-
from typing import Union
2+
from typing import Optional
33

44
from ninja_extra import ControllerBase
55

@@ -12,5 +12,5 @@
1212
class CrudAPIController(ControllerBase, CrudAPI, metaclass=CrudApiMetaclass):
1313
"""For Client facing APIs"""
1414

15-
def __init__(self, service: Union["BaseService", None] = None):
16-
super().__init__(service=service) # pragma: no cover
15+
def __init__(self, service: Optional["BaseService"] = None):
16+
super().__init__(service=service) # type: ignore

easy/domain/serializers.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,11 @@ def serialize_foreign_key(
7070
) -> Dict[Any, Any]:
7171
"""Serializes foreign key field of Django model instance"""
7272
if not hasattr(obj, field.name):
73-
return {field.name: None} # pragma: no cover
73+
return {field.name: None}
7474
related_instance = getattr(obj, field.name)
7575
if related_instance is None:
7676
return {field.name: None}
77-
if related_instance in referrers: # pragma: no cover
77+
if related_instance in referrers:
7878
return {}
7979
return {field.name: getattr(related_instance, "pk")}
8080
# TODO: recursive
@@ -102,5 +102,5 @@ def serialize_many_relationship(
102102
def serialize_value_field(obj: models.Model, field: Any) -> Dict[Any, Any]:
103103
"""Serializes regular 'jsonable' field (Char, Int, etc.) of Django model instance"""
104104
if field.name in ["password"]:
105-
return {} # pragma: no cover
105+
return {}
106106
return {field.name: getattr(obj, field.name)}

easy/services/base.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import logging
2-
from typing import Type, Union
2+
from typing import Optional, Type
33

44
from django.db import models
55

@@ -14,11 +14,11 @@ class BaseService(CrudService, PermissionService):
1414
def __init__(
1515
self,
1616
model: models.Model,
17-
biz: Union[Type[BaseDomain], None] = None,
17+
biz: Optional[Type[BaseDomain]] = None,
1818
):
1919
self.biz = biz
2020
if self.biz:
21-
self.model = self.biz.model # pragma: no cover
21+
self.model = self.biz.model
2222
else:
2323
self.model = model
2424
super().__init__(model=self.model)

0 commit comments

Comments
 (0)