Skip to content

Commit a248920

Browse files
fix: divider margin (#508)
* fix: divider margin * fix: tests
1 parent 841e495 commit a248920

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

src/components/experimental/Divider/Divider.spec.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,16 @@ describe('Experimental: Divider', () => {
3838
const dividerInstance = screen.getByTestId('vertical-divider-experimental');
3939
const dividerStyle = window.getComputedStyle(dividerInstance);
4040

41-
expect(dividerStyle.marginTop).toBe('1rem');
42-
expect(dividerStyle.marginBottom).toBe('1rem');
41+
expect(dividerStyle.marginTop).toBe('0.5rem');
42+
expect(dividerStyle.marginBottom).toBe('0.5rem');
4343
});
4444

4545
it('renders vertical divider with 1rem offset when variant is inset', () => {
4646
render(<Divider vertical variant="inset" />);
4747
const dividerInstance = screen.getByTestId('vertical-divider-experimental');
4848
const dividerStyle = window.getComputedStyle(dividerInstance);
4949

50-
expect(dividerStyle.marginTop).toBe('1rem');
50+
expect(dividerStyle.marginTop).toBe('0.5rem');
5151
expect(dividerStyle.marginBottom).toBe('');
5252
});
5353

@@ -57,7 +57,7 @@ describe('Experimental: Divider', () => {
5757
const dividerStyle = window.getComputedStyle(dividerInstance);
5858

5959
expect(dividerStyle.marginRight).toBe('');
60-
expect(dividerStyle.marginLeft).toBe('1rem');
60+
expect(dividerStyle.marginLeft).toBe('0.5rem');
6161
});
6262

6363
it('renders horizontal divider with overridden offset when variant is inset', () => {
@@ -74,8 +74,8 @@ describe('Experimental: Divider', () => {
7474
const dividerInstance = screen.getByTestId('horizontal-divider-experimental');
7575
const dividerStyle = window.getComputedStyle(dividerInstance);
7676

77-
expect(dividerStyle.marginRight).toBe('1rem');
78-
expect(dividerStyle.marginLeft).toBe('1rem');
77+
expect(dividerStyle.marginRight).toBe('0.5rem');
78+
expect(dividerStyle.marginLeft).toBe('0.5rem');
7979
});
8080

8181
it('renders horizontal divider with overridden offset when variant is middle-inset', () => {
@@ -84,6 +84,6 @@ describe('Experimental: Divider', () => {
8484
const dividerStyle = window.getComputedStyle(dividerInstance);
8585

8686
expect(dividerStyle.marginRight).toBe('2rem');
87-
expect(dividerStyle.marginLeft).toBe('1rem');
87+
expect(dividerStyle.marginLeft).toBe('0.5rem');
8888
});
8989
});

src/components/experimental/Divider/Divider.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ const horizontalVariants = variant({
2222
minWidth: '100%'
2323
},
2424
inset: {
25-
marginLeft: '1rem'
25+
marginLeft: '0.5rem'
2626
},
2727
'middle-inset': {
28-
marginLeft: '1rem',
29-
marginRight: '1rem'
28+
marginLeft: '0.5rem',
29+
marginRight: '0.5rem'
3030
}
3131
}
3232
});
@@ -38,11 +38,11 @@ const verticalVariants = variant({
3838
minHeight: '100%'
3939
},
4040
inset: {
41-
marginTop: '1rem'
41+
marginTop: '0.5rem'
4242
},
4343
'middle-inset': {
44-
marginTop: '1rem',
45-
marginBottom: '1rem'
44+
marginTop: '0.5rem',
45+
marginBottom: '0.5rem'
4646
}
4747
}
4848
});

0 commit comments

Comments
 (0)