Skip to content

Commit 89eeb1c

Browse files
committed
Inline Mockery.reset_instance into Mockery.teardown
1 parent b57c386 commit 89eeb1c

File tree

5 files changed

+6
-10
lines changed

5 files changed

+6
-10
lines changed

lib/mocha/hooks.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ def mocha_verify(assertion_counter = nil)
3838
# This method should be called after each individual test has finished (including after any "teardown" code).
3939
def mocha_teardown
4040
Mockery.teardown
41-
ensure
42-
Mockery.reset_instance
4341
end
4442
end
4543
end

lib/mocha/mockery.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,7 @@ def verify(*args)
5555

5656
def teardown
5757
instance.teardown
58-
end
59-
60-
def reset_instance
58+
ensure
6159
@instances.pop
6260
@instances = nil if instances.empty?
6361
end

test/acceptance/prevent_use_of_mocha_outside_test_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class PreventUseOfMochaOutsideTestTest < Mocha::TestCase
88

99
def setup
1010
setup_acceptance_test
11-
Mocha::Mockery.reset_instance
11+
mocha_teardown
1212
end
1313

1414
def teardown

test/unit/mockery_test.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ def setup
1414
end
1515

1616
def teardown
17-
Mockery.reset_instance
17+
Mockery.teardown
1818
end
1919

2020
def test_should_return_null_mockery_if_not_setup
21-
Mockery.reset_instance
21+
Mockery.teardown
2222
mockery = Mockery.instance
2323
assert_not_nil mockery
2424
assert_kind_of Mockery::Null, mockery
@@ -38,7 +38,7 @@ def test_should_cache_instance_of_mockery
3838

3939
def test_should_expire_mockery_instance_cache
4040
mockery_1 = Mockery.instance
41-
Mockery.reset_instance
41+
Mockery.teardown
4242
mockery_2 = Mockery.instance
4343
assert_not_same mockery_1, mockery_2
4444
end

test/unit/object_methods_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ def setup
1212
end
1313

1414
def teardown
15-
Mocha::Mockery.reset_instance
15+
Mocha::Mockery.teardown
1616
end
1717

1818
def test_should_build_mocha_referring_to_self

0 commit comments

Comments
 (0)