Skip to content

Commit 9172bd4

Browse files
committed
Fix logger LoadError
The logger default gem became bundled in Ruby v4.0 [1] and so it needs to be added as a dependency in the gemspec. This was somehow causing spec failures due to the LoadError being swallowed in `YARD::Templates::Helpers::MarkupHelper#load_markup_provider`. I've also had to add it to the Gemfile, because the specs don't seem to use the gemspec. [1]: https://rubyreferences.github.io/rubychanges/4.0.html#default-gems-that-became-bundled
1 parent 3265ff3 commit 9172bd4

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

Gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ source 'https://rubygems.org'
44
group :development do
55
if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('4.0.0')
66
gem 'irb'
7+
gem 'logger'
78
end
89
gem 'rspec', '>= 3.11.0'
910
gem 'rake'

yard.gemspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,6 @@ Gem::Specification.new do |s|
2222
s.metadata['yard.run'] = 'yri'
2323
if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('4.0.0')
2424
s.add_dependency 'irb'
25+
s.add_dependency 'logger'
2526
end
2627
end

0 commit comments

Comments
 (0)