Issue with 1.8.200 - Improved PHP 8.5 compatibility

[sofl88]

Hello.

After changing $http_response_header to $http_response_header_local

1.8.199...1.8.200#diff-6d5877e96852a677f1d6a3d8386229797fe37d239d2dfc9bdf93d1aae2b1cb8aR323-R325

freescout/overrides/guzzlehttp/guzzle/src/Handler/StreamHandler.php

Line 323 in 1a4abad

function () use ($uri, &$http_response_header_local, $context, $options) {

freescout/overrides/guzzlehttp/guzzle/src/Handler/StreamHandler.php

Line 325 in 1a4abad

$this->lastHeaders = $http_response_header_local;

I get the following error

Type error: array_shift(): Argument #1 ($array) must be of type array, null given

freescout/overrides/guzzlehttp/guzzle/src/Handler/StreamHandler.php

Line 102 in 1a4abad

$parts = explode(' ', array_shift($hdrs), 3);

To be fair, I have some adjustments to establish an aws-s3 connection but in any case the $this->lastHeaders property should be NULL since $http_response_header is an auto filled variable in php https://www.php.net/manual/de/reserved.variables.httpresponseheader.php

Is this a mistake or is this intended?

Thanks in advance

PHP version: 8.3.29
FreeScout version: 1.8.201
Database: MySQL
Are you using CloudFlare: No
Are you using non-official modules: Yes

[freescout-help]

When are you receiving this error? Can you share the full error log message.

[sofl88]

Maybe it only fails with the aws adapter. Its ok if you say thats none of your business since its not part of the basic project.

edit: I get this error basically evertime I request a file from aws. In this case the user avatar.

[stacktrace]
#0 /var/www/freescout/overrides/guzzlehttp/guzzle/src/Handler/StreamHandler.php(102): array_shift()
#1 /var/www/freescout/overrides/guzzlehttp/guzzle/src/Handler/StreamHandler.php(49): GuzzleHttp\\Handler\\StreamHandler->createResponse()
#2 /var/www/freescout/vendor/guzzlehttp/guzzle/src/Handler/Proxy.php(52): GuzzleHttp\\Handler\\StreamHandler->__invoke()
#3 /var/www/freescout/vendor/guzzlehttp/guzzle/src/PrepareBodyMiddleware.php(37): GuzzleHttp\\Handler\\Proxy::GuzzleHttp\\Handler\\{closure}()
#4 /var/www/freescout/overrides/guzzlehttp/guzzle/src/Middleware.php(29): GuzzleHttp\\PrepareBodyMiddleware->__invoke()
#5 /var/www/freescout/vendor/guzzlehttp/guzzle/src/RedirectMiddleware.php(70): GuzzleHttp\\Middleware::GuzzleHttp\\{closure}()
#6 /var/www/freescout/overrides/guzzlehttp/guzzle/src/Middleware.php(59): GuzzleHttp\\RedirectMiddleware->__invoke()
#7 /var/www/freescout/overrides/guzzlehttp/guzzle/src/HandlerStack.php(71): GuzzleHttp\\Middleware::GuzzleHttp\\{closure}()
#8 /var/www/freescout/overrides/guzzlehttp/guzzle/src/Client.php(351): GuzzleHttp\\HandlerStack->__invoke()
#9 /var/www/freescout/overrides/guzzlehttp/guzzle/src/Client.php(111): GuzzleHttp\\Client->transfer()
#10 /var/www/freescout/vendor/aws/aws-sdk-php/src/Handler/GuzzleV6/GuzzleHandler.php(43): GuzzleHttp\\Client->sendAsync()
#11 /var/www/freescout/vendor/aws/aws-sdk-php/src/WrappedHttpHandler.php(88): Aws\\Handler\\GuzzleV6\\GuzzleHandler->__invoke()
#12 /var/www/freescout/vendor/aws/aws-sdk-php/src/ClientSideMonitoring/AbstractMonitoringMiddleware.php(126): Aws\\WrappedHttpHandler->__invoke()
#13 /var/www/freescout/vendor/aws/aws-sdk-php/src/S3/PermanentRedirectMiddleware.php(43): Aws\\ClientSideMonitoring\\AbstractMonitoringMiddleware->__invoke()
#14 /var/www/freescout/vendor/aws/aws-sdk-php/src/S3/PutObjectUrlMiddleware.php(41): Aws\\S3\\PermanentRedirectMiddleware->__invoke()
#15 /var/www/freescout/vendor/aws/aws-sdk-php/src/S3/ExpiresParsingMiddleware.php(42): Aws\\S3\\PutObjectUrlMiddleware->__invoke()
#16 /var/www/freescout/vendor/aws/aws-sdk-php/src/Middleware.php(154): Aws\\S3\\ExpiresParsingMiddleware->__invoke()
#17 /var/www/freescout/overrides/guzzlehttp/promises/src/FulfilledPromise.php(41): Aws\\Middleware::Aws\\{closure}()
#18 /var/www/freescout/vendor/guzzlehttp/promises/src/TaskQueue.php(48): GuzzleHttp\\Promise\\FulfilledPromise::GuzzleHttp\\Promise\\{closure}()
#19 /var/www/freescout/overrides/guzzlehttp/promises/src/Promise.php(248): GuzzleHttp\\Promise\\TaskQueue->run()
#20 /var/www/freescout/overrides/guzzlehttp/promises/src/Promise.php(224): GuzzleHttp\\Promise\\Promise->invokeWaitFn()
#21 /var/www/freescout/overrides/guzzlehttp/promises/src/Promise.php(269): GuzzleHttp\\Promise\\Promise->waitIfPending()
#22 /var/www/freescout/overrides/guzzlehttp/promises/src/Promise.php(226): GuzzleHttp\\Promise\\Promise->invokeWaitList()
#23 /var/www/freescout/overrides/guzzlehttp/promises/src/Promise.php(62): GuzzleHttp\\Promise\\Promise->waitIfPending()
#24 /var/www/freescout/vendor/aws/aws-sdk-php/src/AwsClientTrait.php(58): GuzzleHttp\\Promise\\Promise->wait()
#25 /var/www/freescout/vendor/league/flysystem-aws-s3-v3/src/AwsS3Adapter.php(477): Aws\\AwsClient->execute()
#26 /var/www/freescout/vendor/league/flysystem-aws-s3-v3/src/AwsS3Adapter.php(445): League\\Flysystem\\AwsS3v3\\AwsS3Adapter->readObject()
#27 /var/www/freescout/overrides/league/flysystem/src/Filesystem.php(197): League\\Flysystem\\AwsS3v3\\AwsS3Adapter->readStream()
#28 /var/www/freescout/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php(135): League\\Flysystem\\Filesystem->readStream()
#29 /var/www/freescout/overrides/symfony/http-foundation/StreamedResponse.php(114): Illuminate\\Filesystem\\FilesystemAdapter->Illuminate\\Filesystem\\{closure}()
#30 /var/www/freescout/overrides/symfony/http-foundation/Response.php(373): Symfony\\Component\\HttpFoundation\\StreamedResponse->sendContent()
#31 /var/www/freescout/public/index.php(86): Symfony\\Component\\HttpFoundation\\Response->send()
#32 {main}
"}

[freescout-help]

Try this fix: 8c99abc

[sofl88]

This fix works for me. I noted that the reference in use is still &$http_response_header_local but it works regardless.