assets: Ditch top light setting.

Author: freezy

VisualPinball.Unity/VisualPinball.Unity.Editor/AssetBrowser/AssetStructure/Asset.cs

@@ -64,17 +64,14 @@ public class Asset : ScriptableObject
 		public List<AssetMaterialVariation> MaterialVariations;
 
 		[SerializeField]
-		public string ThumbBackgroundObjectName;
+		public string EnvironmentGameObjectName;
 
 		[SerializeReference]
 		public Preset ThumbCameraPreset;
 
 		[SerializeField]
 		public float ThumbCameraHeight;
 
-		[SerializeField]
-		public bool ThumbTopLight;
-		
 		[SerializeField]
 		public bool UnpackPrefab;
 

VisualPinball.Unity/VisualPinball.Unity.Editor/AssetBrowser/AssetStructure/AssetDetails.cs

@@ -171,7 +171,7 @@ public void Bind(Asset asset)
 
 		private void BindBackgroundObjects()
 		{
-			var bgo = _body.Q<ObjectDropdownElement>("background-object-field");
+			var bgo = _body.Q<ObjectDropdownElement>("environment-field");
 			var bgParent = SceneManager.GetActiveScene().GetRootGameObjects()
 					.FirstOrDefault(go => go.name == "_BackgroundObjects");
 
@@ -180,14 +180,14 @@ private void BindBackgroundObjects()
 				return;
 			}
 			bgo.visible = true;
-			bgo.Value = _asset.ThumbBackgroundObjectName != null ? bgParent.transform.Find(_asset.ThumbBackgroundObjectName)?.gameObject : null;
+			bgo.Value = _asset.EnvironmentGameObjectName != null ? bgParent.transform.Find(_asset.EnvironmentGameObjectName)?.gameObject : null;
 			bgo.AddObjectsToDropdown<MeshRenderer>(bgParent, true);
-			bgo.RegisterValueChangedCallback(OnThumbBackgroundObjectChanged);
+			bgo.RegisterValueChangedCallback(OnThumbEnvironmentChanged);
 		}
 
-		private void OnThumbBackgroundObjectChanged(Object obj)
+		private void OnThumbEnvironmentChanged(Object obj)
 		{
-			_asset.ThumbBackgroundObjectName = obj.name;
+			_asset.EnvironmentGameObjectName = obj.name;
 		}
 
 		private void BindInfo(Asset asset)

VisualPinball.Unity/VisualPinball.Unity.Editor/AssetBrowser/AssetStructure/AssetDetails_Body.uxml

@@ -33,10 +33,9 @@
 	<!-- Geometry -->
 	<ui:Foldout text="Thumbnail Settings">
 		<ui:VisualElement class="left-indent">
-			<uivpe:ObjectDropdownElement name="background-object-field" label="On Object" />
+			<uivpe:ObjectDropdownElement name="environment-field" label="Environment" />
 			<uivpe:PresetDropdownElement name="thumb-camera-preset" binding-path="ThumbCameraPreset" label="Camera" preset-path="Packages/org.visualpinball.engine.unity/VisualPinball.Unity/Assets/Presets/Asset Thumbcam" />
 			<uie:PropertyField binding-path="ThumbCameraHeight" label="Z-Position" />
-			<uie:PropertyField binding-path="ThumbTopLight" label="Enable Top Light" />
 		</ui:VisualElement>
 	</ui:Foldout>
 

VisualPinball.Unity/VisualPinball.Unity.Editor/VPT/Kicker/KickerInspector.cs

@@ -101,7 +101,7 @@ private void OnSceneGUI()
 			var localPos = MainComponent.GetEditorPosition();
 			localPos.z = MainComponent.PositionZ;
 
-			var worldPos = transform.parent.TransformPoint(localPos);
+			var worldPos = transform.parent == null ? localPos : transform.parent.TransformPoint(localPos);
 
 			foreach (var coil in MainComponent.Coils) {
 				var from = MainComponent.GetBallCreationPosition().ToUnityVector3();