workflows: add check that models have _nice values

Author: Noki

.github/checks/check-model-nice.sh

@@ -0,0 +1,42 @@
+#!/bin/bash
+
+# Check that all model files have brand_nice and model_nice set,
+# with the exception of x86 models
+
+if [ "$#" -gt 0 ]; then
+	model_files=("$@")
+else
+	model_files=(group_vars/model_*.yml)
+fi
+
+error_found=0
+
+for file in "${model_files[@]}"; do
+	if [ ! -f "$file" ]; then
+		echo "File $file does not exist, skipping."
+		continue
+	fi
+
+	if [[ "$file" == *"_x86"* ]]; then
+		continue
+	fi
+
+	brand_nice=$(yq -r '.brand_nice // ""' "$file" 2>/dev/null || true)
+	model_nice=$(yq -r '.model_nice // ""' "$file" 2>/dev/null || true)
+
+	if [ -z "$brand_nice" ]; then
+		echo "Error: $file missing 'brand_nice'"
+		error_found=1
+	fi
+
+	if [ -z "$model_nice" ]; then
+		echo "Error: $file missing 'model_nice'"
+		error_found=1
+	fi
+done
+
+if [ "$error_found" -eq 1 ]; then
+	exit 1
+else
+	echo "All model files have brand_nice and model_nice set"
+fi

.github/workflows/check-model-nice.yml

@@ -0,0 +1,30 @@
+---
+name: Check model nice fields
+
+on: [push, pull_request]
+
+permissions:
+  contents: read
+  actions: read
+
+jobs:
+  check-model-nice:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 0
+
+      - name: Run model nice fields check
+        run: |
+          git fetch origin main
+          changed_files=$(git diff --name-only origin/main)
+          model_files=$(echo "$changed_files" | grep -E '^group_vars/model_.*\.yml$' || true)
+          if [ -z "$model_files" ]; then
+            echo "No model files changed, running against all models"
+            bash ./.github/checks/check-model-nice.sh
+          else
+            echo "Running check on changed model files"
+            bash ./.github/checks/check-model-nice.sh "$model_files"
+          fi