Skip to content

Commit 8d8efbb

Browse files
committed
feat!(frender_dom): behaviors::Node::warn_self_with_message
1 parent 724d3d5 commit 8d8efbb

File tree

5 files changed

+27
-1
lines changed

5 files changed

+27
-1
lines changed

packages/frender-dom/src/behaviors.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ pub trait NodeWithRenderContextAfterSelf<Renderer: ?Sized + RenderWithContext> {
2020
pub trait Node<Renderer: ?Sized> {
2121
fn log_self(&self, renderer: &mut Renderer);
2222

23+
fn warn_self_with_message(&self, renderer: &mut Renderer, message: &str);
24+
2325
/// Should move the node if `force_reposition`,
2426
/// and move cursor after the node.
2527
fn readd_self(
@@ -100,6 +102,10 @@ impl<N: AsRef<web_sys::Node>, Renderer: ?Sized + crate::csr::web::Renderer> Node
100102
web_sys::console::log_1(self.0.as_ref());
101103
}
102104

105+
fn warn_self_with_message(&self, _: &mut Renderer, message: &str) {
106+
web_sys::console::warn_2(self.0.as_ref(), &message.into());
107+
}
108+
103109
fn cursor_is_at_self(&self, render_context: &Renderer::RenderContext<'_>) -> bool
104110
where
105111
Renderer: crate::render::RenderWithContext,

packages/frender-dom/src/csr/web/cursor_place_holder.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,11 @@ impl<R: ?Sized + Renderer> UiHandle<R> for CursorPlaceholder {
5353

5454
impl<R: ?Sized + Renderer> behaviors::Node<R> for CursorPlaceholder {
5555
fn log_self(&self, _: &mut R) {
56-
web_sys::console::log_2(&"CursorPlaceholder".into(), &self.0);
56+
web_sys::console::log_3(&"CursorPlaceholder".into(), &self.0, &self.0);
57+
}
58+
59+
fn warn_self_with_message(&self, _: &mut R, message: &str) {
60+
web_sys::console::warn_3(&"CursorPlaceholder".into(), &self.0, &message.into());
5761
}
5862

5963
fn readd_self(&mut self, render_context: &mut <R>::RenderContext<'_>, force_reposition: bool)

packages/frender-html/src/element_proxy_attrs.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,10 @@ mod dom {
8383
self.0.log_self(renderer)
8484
}
8585

86+
fn warn_self_with_message(&self, renderer: &mut R, message: &str) {
87+
self.0.warn_self_with_message(renderer, message)
88+
}
89+
8690
fn cursor_is_at_self(&self, render_context: &<R>::RenderContext<'_>) -> bool
8791
where
8892
R: frender_dom::render::RenderWithContext,

packages/frender-test/src/element.rs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -382,6 +382,10 @@ mod cursor_placeholder {
382382
eprintln!("{:?}", self)
383383
}
384384

385+
fn warn_self_with_message(&self, _: &mut Renderer, message: &str) {
386+
eprintln!("WARNING: {:?} {}", self, message)
387+
}
388+
385389
fn readd_self(&mut self, render_context: &mut RenderContext, force_reposition: bool) {
386390
render_context.readd_node(
387391
Cow::Owned(Node::CursorPlaceholder(self.clone())),
@@ -450,6 +454,10 @@ mod dom {
450454
eprintln!("{:?}", self)
451455
}
452456

457+
fn warn_self_with_message(&self, renderer: &mut Renderer, message: &str) {
458+
eprintln!("WARNING: {:?} {}", self, message)
459+
}
460+
453461
fn cursor_is_at_self(&self, render_context: &crate::renderer::RenderContext<'_>) -> bool {
454462
render_context
455463
.current_node()

packages/frender-test/src/text.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@ impl frender_html::dom::behaviors::Node<Renderer> for Text {
5151
eprintln!("{:?}", self)
5252
}
5353

54+
fn warn_self_with_message(&self, _: &mut Renderer, message: &str) {
55+
eprintln!("WARNING: {:?} {}", self, message)
56+
}
57+
5458
fn cursor_is_at_self(&self, renderer: &crate::renderer::RenderContext) -> bool {
5559
renderer.cursor_is_at(|node| matches!(node, Node::Text(t) if t.is_same_text(self)))
5660
}

0 commit comments

Comments
 (0)