Skip to content

Commit 97e2429

Browse files
committed
feat: better debug messages
1 parent 29c398d commit 97e2429

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

packages/frender-csr-web/src/renderer.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ impl frender_html::dom::csr::web::Renderer for Renderer {
248248
where
249249
Self: RenderWithContext,
250250
{
251-
debug_assert!(render_context.cursor.cursor_is_at_node(node))
251+
render_context.cursor.debug_assert_cursor_is_at_node(node)
252252
}
253253

254254
fn reposition_node(render_context: &mut Self::RenderContext<'_>, node: &web_sys::Node)

packages/frender-dom/src/csr/web.rs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ pub trait Renderer: for<'a> RenderWithContext<RenderContext<'a> = RenderContext<
8080
) where
8181
Self: RenderWithContext;
8282

83+
// TODO: rename to debug_assert*
8384
fn assert_cursor_is_at_node(render_context: &Self::RenderContext<'_>, node: &web_sys::Node)
8485
where
8586
Self: RenderWithContext;
@@ -236,7 +237,16 @@ impl<'a> Cursor<'a> {
236237
}
237238

238239
fn check_cursor_is_at_node_or_warn(&self, node: &web_sys::Node) {
240+
self.debug_assert_cursor_is_at_node(node)
241+
}
242+
243+
/// Panics on `#[cfg(debug_assertions)]`
244+
pub fn debug_assert_cursor_is_at_node(&self, node: &web_sys::Node) {
239245
#[cfg(debug_assertions)]
246+
self.assert_cursor_is_at_node(node)
247+
}
248+
249+
fn assert_cursor_is_at_node(&self, node: &web_sys::Node) {
240250
if !(self.skipped || self.cursor_is_at_node(node)) {
241251
web_sys::console::log_3(
242252
&"[debug assertion failed] Cursor should be at:".into(),

0 commit comments

Comments
 (0)