Skip to content

Commit daa5931

Browse files
committed
feat: create_element* should take references of props and children
BREAKING CHANGE: `create_element*` now takes references of props and children
1 parent 0ebd140 commit daa5931

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/element.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ crate::macro_import::wasm_bindgen_react! {
99
pub fn create_element_no_props(element_type: &JsValue) -> Element;
1010

1111
#[wasm_bindgen(js_namespace = React, js_name = createElement)]
12-
pub fn create_element_with_props(element_type: &JsValue, props: JsValue) -> Element;
12+
pub fn create_element_with_props(element_type: &JsValue, props: &JsValue) -> Element;
1313

1414
#[wasm_bindgen(variadic, js_namespace = React, js_name = createElement)]
1515
pub fn create_element(
1616
element_type: &JsValue,
17-
props: JsValue,
18-
children: js_sys::Array,
17+
props: &JsValue,
18+
children: &js_sys::Array,
1919
) -> Element;
2020

2121
/// # Safety
@@ -24,8 +24,8 @@ crate::macro_import::wasm_bindgen_react! {
2424
#[wasm_bindgen(variadic, js_namespace = React, js_name = createElement)]
2525
pub unsafe fn create_element_fn(
2626
element_type: &Closure<dyn Fn(js_sys::Object) -> Element>,
27-
props: JsValue,
28-
children: js_sys::Array,
27+
props: &JsValue,
28+
children: &js_sys::Array,
2929
) -> Element;
3030

3131
/// # Safety
@@ -34,7 +34,7 @@ crate::macro_import::wasm_bindgen_react! {
3434
#[wasm_bindgen(variadic, js_namespace = React, js_name = createElement)]
3535
pub unsafe fn create_element_fn_mut(
3636
element_type: &Closure<dyn FnMut(js_sys::Object) -> Element>,
37-
props: JsValue,
38-
children: js_sys::Array,
37+
props: &JsValue,
38+
children: &js_sys::Array,
3939
) -> Element;
4040
}

0 commit comments

Comments
 (0)