Commit 2a0ca00
committed
Remove
This commit removes the `SensorMetricSample` message in favour of using
`MetricSample` for sensors. The `SensorMetricSample` message was
a subset of the `MetricSample` message.
From a design perspective focused on consistency, flexibility, and
minimizing API surface area while handling variations via optional
fields (which is idiomatic in Protobuf3), there's a strong argument that
`SensorMetricSample` is redundant and potentially confusing, and that
having only `MetricSample` is a cleaner design.
Signed-off-by: Tiyash Basu <[email protected]>SensorMetricSample in favour of MetricSample
1 parent d863621 commit 2a0ca00
File tree
2 files changed
+6
-1
lines changed- proto/frequenz/api/common/v1/microgrid/sensors
2 files changed
+6
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| 38 | + | |
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
| |||
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
233 | 233 | | |
234 | 234 | | |
235 | 235 | | |
| 236 | + | |
| 237 | + | |
236 | 238 | | |
237 | 239 | | |
238 | 240 | | |
239 | 241 | | |
240 | 242 | | |
| 243 | + | |
| 244 | + | |
241 | 245 | | |
242 | 246 | | |
243 | 247 | | |
| |||
254 | 258 | | |
255 | 259 | | |
256 | 260 | | |
257 | | - | |
| 261 | + | |
258 | 262 | | |
259 | 263 | | |
260 | 264 | | |
| |||
0 commit comments