Skip to content

Commit 778d70b

Browse files
Rename sampled_at to sampled_time in metrics and sensor metrics
Signed-off-by: Tiyash Basu <[email protected]>
1 parent fe88fd1 commit 778d70b

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

RELEASE_NOTES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
- Renamed `ElectricalComponentState` to `ElectricalComponentStateSnapshot` to better reflect its purpose.
3535
- Renamed `SensorState` to `SensorStateSnapshot` to better reflect its purpose.
3636
- Renamed `sampled_at` timestamps for state snapshots to `origin_time`.
37+
- Renamed `sampled_at` timestamps for metric samples to `sampled_time`.
3738

3839
## Bug Fixes
3940

proto/frequenz/api/common/v1/metrics/metrics.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ enum Metric {
186186
// command, clients need to request current values within the bounds.
187187
message MetricSample {
188188
// The UTC timestamp of when the metric was sampled.
189-
google.protobuf.Timestamp sampled_at = 1;
189+
google.protobuf.Timestamp sampled_time = 1;
190190

191191
// The metric that was sampled.
192192
Metric metric = 2;

proto/frequenz/api/common/v1/microgrid/electrical_components/electrical_components.proto

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -524,13 +524,13 @@ message ElectricalComponentStateSnapshot {
524524
// metric_samples: [
525525
// /* list of metrics for multiple timestamps */
526526
// {
527-
// sampled_at: "2023-10-01T00:00:00Z",
527+
// sampled_time: "2023-10-01T00:00:00Z",
528528
// metric: "DC_VOLTAGE_V",
529529
// value: {},
530530
// bounds: {},
531531
// },
532532
// {
533-
// sampled_at: "2023-10-01T00:00:00Z",
533+
// sampled_time: "2023-10-01T00:00:00Z",
534534
// metric: "DC_VOLTAGE_V",
535535
// value: {},
536536
// bounds: {},
@@ -539,13 +539,13 @@ message ElectricalComponentStateSnapshot {
539539
// states: [
540540
// /* list of states for multiple timestamps */
541541
// {
542-
// sampled_at: "2023-10-01T00:00:00Z",
542+
// sampled_time: "2023-10-01T00:00:00Z",
543543
// states: [],
544544
// warnings: [],
545545
// errors: [],
546546
// },
547547
// {
548-
// sampled_at: "2023-10-01T00:00:00Z",
548+
// sampled_time: "2023-10-01T00:00:00Z",
549549
// states: [],
550550
// warnings: [],
551551
// errors: [],

proto/frequenz/api/common/v1/microgrid/sensors/sensors.proto

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ message SensorStateSnapshot {
210210
// Representation of a sampled sensor metric along with its value.
211211
message SensorMetricSample {
212212
// The UTC timestamp of when the metric was sampled.
213-
google.protobuf.Timestamp sampled_at = 1;
213+
google.protobuf.Timestamp sampled_time = 1;
214214

215215
// The metric that was sampled.
216216
frequenz.api.common.v1.metrics.Metric metric = 2;
@@ -230,19 +230,19 @@ message SensorMetricSample {
230230
// metric_samples: [
231231
// /* list of metrics for multiple timestamps */
232232
// {
233-
// sampled_at: "2023-10-01T00:00:00Z",
233+
// sampled_time: "2023-10-01T00:00:00Z",
234234
// metric: "METRIC_SENSOR_TEMPERATURE",
235235
// value: metric_value_variant: {simple_metric: {value: 23.5},
236236
// },
237237
// {
238-
// sampled_at: "2023-10-01T00:00:00Z",
238+
// sampled_time: "2023-10-01T00:00:00Z",
239239
// metric: "METRIC_SENSOR_RELATIVE_HUMIDITY",
240240
// value: metric_value_variant: {simple_metric: {value: 23.5},
241241
// }
242242
// ],
243243
// states: [
244244
// {
245-
// sampled_at: "2023-10-01T00:00:00Z",
245+
// sampled_time: "2023-10-01T00:00:00Z",
246246
// states: [],
247247
// errors: [],
248248
// },

0 commit comments

Comments
 (0)