Remove unnecessary items and add a test (#132)

Author: tiyash-basu-frequenz

RELEASE_NOTES.md

@@ -61,6 +61,8 @@
 
 - Added messages to support pagination in APIs.
 
+- Removed `metrics/electrical.proto`, since it is no longer needed.
+
 ## New Features
 
 <!-- Here goes the main new features and examples or instructions on how to use them -->

proto/frequenz/api/common/v1/metrics/electrical.proto

@@ -134,9 +134,7 @@ enum Metric {
   // General BMS metrics.
   METRIC_BATTERY_CAPACITY = 101;
   METRIC_BATTERY_SOC_PCT = 102;
-  METRIC_BATTERY_SOP_CHARGE = 103;
-  METRIC_BATTERY_SOP_DISCHARGE = 104;
-  METRIC_BATTERY_TEMPERATURE = 105;
+  METRIC_BATTERY_TEMPERATURE = 103;
 
   // General inverter metrics.
   METRIC_INVERTER_TEMPERATURE = 120;

proto/frequenz/api/common/v1/metrics/metric_sample.proto

@@ -12,30 +12,30 @@ def test_package_import() -> None:
     assert v1 is not None
 
 
-def test_module_import_metrics_electrical() -> None:
+def test_module_import_metrics_bounds() -> None:
     """Test that the modules can be imported."""
     # pylint: disable=import-outside-toplevel
-    from frequenz.api.common.v1.metrics import electrical_pb2
+    from frequenz.api.common.v1.metrics import bounds_pb2
 
-    assert electrical_pb2 is not None
+    assert bounds_pb2 is not None
 
     # pylint: disable=import-outside-toplevel
-    from frequenz.api.common.v1.metrics import electrical_pb2_grpc
+    from frequenz.api.common.v1.metrics import bounds_pb2_grpc
 
-    assert electrical_pb2_grpc is not None
+    assert bounds_pb2_grpc is not None
 
 
-def test_module_import_metrics_bounds() -> None:
+def test_module_import_metrics_metric_sample() -> None:
     """Test that the modules can be imported."""
     # pylint: disable=import-outside-toplevel
-    from frequenz.api.common.v1.metrics import bounds_pb2
+    from frequenz.api.common.v1.metrics import metric_sample_pb2
 
-    assert bounds_pb2 is not None
+    assert metric_sample_pb2 is not None
 
     # pylint: disable=import-outside-toplevel
-    from frequenz.api.common.v1.metrics import bounds_pb2_grpc
+    from frequenz.api.common.v1.metrics import metric_sample_pb2_grpc
 
-    assert bounds_pb2_grpc is not None
+    assert metric_sample_pb2_grpc is not None
 
 
 def test_module_import_grid() -> None: