Skip to content

Commit f27503f

Browse files
Fix gaps in metric enum numbers
This commit fixes gaps in the metric enum numbers in the `metric_sample.proto` file. Signed-off-by: Tiyash Basu <[email protected]>
1 parent 8467617 commit f27503f

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

RELEASE_NOTES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
- Added new message `CommunicationComponentStateSnapshot` to represent the state of communication components.
2424
- Added new message definitions for streaming events (Deleted, Created, Updated)
2525
- Remove unnecessary gap in numbering in the `ElectricalComponentCategory` enum.
26+
- Renumber variants in the `Metric` enum to remove unnecessary gaps.
2627

2728
## Bug Fixes
2829

proto/frequenz/api/common/v1/metrics/metric_sample.proto

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,8 @@ enum Metric {
139139
METRIC_AC_ACTIVE_ENERGY_DELIVERED_PHASE_3 = 65;
140140
METRIC_AC_REACTIVE_ENERGY = 66;
141141
METRIC_AC_REACTIVE_ENERGY_PHASE_1 = 67;
142-
METRIC_AC_REACTIVE_ENERGY_PHASE_2 = 69;
143-
METRIC_AC_REACTIVE_ENERGY_PHASE_3 = 70;
142+
METRIC_AC_REACTIVE_ENERGY_PHASE_2 = 68;
143+
METRIC_AC_REACTIVE_ENERGY_PHASE_3 = 69;
144144

145145
// AC harmonics
146146
METRIC_AC_TOTAL_HARMONIC_DISTORTION_CURRENT = 80;
@@ -149,9 +149,9 @@ enum Metric {
149149
METRIC_AC_TOTAL_HARMONIC_DISTORTION_CURRENT_PHASE_3 = 83;
150150

151151
// General BMS metrics.
152-
METRIC_BATTERY_CAPACITY = 101;
153-
METRIC_BATTERY_SOC_PCT = 102;
154-
METRIC_BATTERY_TEMPERATURE = 103;
152+
METRIC_BATTERY_CAPACITY = 100;
153+
METRIC_BATTERY_SOC_PCT = 101;
154+
METRIC_BATTERY_TEMPERATURE = 102;
155155

156156
// General inverter metrics.
157157
METRIC_INVERTER_TEMPERATURE = 120;
@@ -164,12 +164,12 @@ enum Metric {
164164

165165
// General sensor metrics
166166
METRIC_SENSOR_WIND_SPEED = 160;
167-
METRIC_SENSOR_WIND_DIRECTION = 162;
168-
METRIC_SENSOR_TEMPERATURE = 163;
169-
METRIC_SENSOR_RELATIVE_HUMIDITY = 164;
170-
METRIC_SENSOR_DEW_POINT = 165;
171-
METRIC_SENSOR_AIR_PRESSURE = 166;
172-
METRIC_SENSOR_IRRADIANCE = 167;
167+
METRIC_SENSOR_WIND_DIRECTION = 161;
168+
METRIC_SENSOR_TEMPERATURE = 162;
169+
METRIC_SENSOR_RELATIVE_HUMIDITY = 163;
170+
METRIC_SENSOR_DEW_POINT = 164;
171+
METRIC_SENSOR_AIR_PRESSURE = 165;
172+
METRIC_SENSOR_IRRADIANCE = 166;
173173
}
174174

175175
// Representation of a sampled metric along with its value.

0 commit comments

Comments
 (0)