Rename grid to grid_connection_point in electrical_components.proto #335
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates naming in electrical_components.proto to rename the electrical component category from GRID to GRID_CONNECTION_POINT and adjusts the corresponding oneof variant field accordingly.
- Renamed the enum constant ELECTRICAL_COMPONENT_CATEGORY_GRID to ELECTRICAL_COMPONENT_CATEGORY_GRID_CONNECTION_POINT.
- Updated the oneof variant field from grid to grid_connection_point.
- Updated RELEASE_NOTES.md to document these naming changes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| proto/frequenz/api/common/v1/microgrid/electrical_components/electrical_components.proto | Renaming of enum constant and oneof field to better reflect their purpose. |
| RELEASE_NOTES.md | Updated notes to reflect the renaming changes. |
proto/frequenz/api/common/v1/microgrid/electrical_components/electrical_components.proto
Show resolved
Hide resolved
tiyash-basu-frequenz
force-pushed
the
255_grid
branch
from
2f7e20d to
619317d
Compare
llucax
previously approved these changes
May 19, 2025
tiyash-basu-frequenz
force-pushed
the
255_grid
branch
from
619317d to
98299b1
Compare
Contributor
Author
|
Rebased. Needs another look 🙏 |
tiyash-basu-frequenz
force-pushed
the
255_grid
branch
from
98299b1 to
9828f39
Compare
This commit renames the electrical component category `COMPONENT_CATEGORY_GRID` to `ELECTRICAL_COMPONENT_CATEGORY_GRID_CONNECTION_POINT` in the proto file. (the name change of the enum is part of a larger refactoring of the electrical component category enum). The oneof variant `ComponentCategoryMetadataVariant.metadata.grid` has also been renamed to `ElectricalComponentCategorySpecificInfo.info.grid_connection_point` to better reflect its purpose. Signed-off-by: Tiyash Basu <[email protected]>
tiyash-basu-frequenz
force-pushed
the
255_grid
branch
from
9828f39 to
9ce1d51
Compare
llucax
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames the electrical component category
COMPONENT_CATEGORY_GRIDtoELECTRICAL_COMPONENT_CATEGORY_GRID_CONNECTION_POINTin the proto file. (the name change of the enum is part of a larger refactoring of the electrical component category enum).The oneof variant
ComponentCategoryMetadataVariant.metadata.gridhas also been renamed toElectricalComponentCategorySpecificInfo.info.grid_connection_pointto better reflect its purpose.closes #255