Skip to content

Commit 83515b1

Browse files
Add update_time field to Dispatch message (#23)
Fixes #21
2 parents 5e9e56d + 214ec91 commit 83515b1

File tree

2 files changed

+29
-24
lines changed

2 files changed

+29
-24
lines changed

RELEASE_NOTES.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Release notes
22

3-
- The `FcrPrequalificationSettings` message has been removed, and settings
4-
fields have been modified/reverted to use protobuf Structs, in order to
5-
represent arbitrary JSON objects.
3+
- The field `create_time` has been removed from update requests.
4+
- An `update_time` field has been added to the Dispatch object.
5+
- The `type` field has been removed from update requests, to prevent it from being modified after creation.

proto/frequenz/api/dispatch/dispatch.proto

Lines changed: 26 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -56,26 +56,31 @@ message Dispatch {
5656
// understanding and processing this field.
5757
string type = 3;
5858

59+
// The creation time
60+
// This is set when a dispatch is created via the create request message
61+
google.protobuf.Timestamp create_time = 4;
62+
63+
// The update time
64+
// This is set when a dispatch is modified via the update request message
65+
google.protobuf.Timestamp update_time = 5;
66+
5967
// The start time
60-
google.protobuf.Timestamp start_time = 4;
68+
google.protobuf.Timestamp start_time = 6;
6169

6270
// The end time
63-
google.protobuf.Timestamp end_time = 5;
71+
google.protobuf.Timestamp end_time = 7;
6472

6573
// The component selector
66-
DispatchComponentSelector selector = 6;
67-
68-
// The creation time
69-
google.protobuf.Timestamp create_time = 7;
74+
DispatchComponentSelector selector = 8;
7075

7176
// The "active" status
72-
bool is_active = 8;
77+
bool is_active = 9;
7378

7479
// The "dry run" status
75-
bool is_dry_run = 9;
80+
bool is_dry_run = 10;
7681

7782
// The dispatch payload
78-
google.protobuf.Struct payload = 10;
83+
google.protobuf.Struct payload = 11;
7984
}
8085

8186
// Filter parameter for specifying multiple time intervals
@@ -151,6 +156,9 @@ message DispatchCreateRequest {
151156
string type = 2;
152157

153158
// The start time
159+
// When creating a dispatch, ensure that the starting timestamp is set to
160+
// the current time or any future time.
161+
// Timestamps earlier than the current time are not allowed.
154162
google.protobuf.Timestamp start_time = 3;
155163

156164
// The end time
@@ -177,27 +185,24 @@ message DispatchUpdateRequest {
177185
// The microgrid identifier
178186
optional uint64 microgrid_id = 2;
179187

180-
// The type of dispatch
181-
optional string type = 3;
182-
183188
// The start time
184-
google.protobuf.Timestamp start_time = 4;
189+
// When updating a dispatch, ensure that the starting timestamp is set to
190+
// the current time or any future time.
191+
// Timestamps earlier than the current time are not allowed.
192+
google.protobuf.Timestamp start_time = 3;
185193

186194
// The end time
187-
google.protobuf.Timestamp end_time = 5;
195+
google.protobuf.Timestamp end_time = 4;
188196

189197
// The component selector
190-
DispatchComponentSelector selector = 6;
191-
192-
// The creation time
193-
google.protobuf.Timestamp create_time = 7;
198+
DispatchComponentSelector selector = 5;
194199

195200
// The "active" status
196-
optional bool is_active = 8;
201+
optional bool is_active = 6;
197202

198203
// The "dry run" status
199-
optional bool is_dry_run = 9;
204+
optional bool is_dry_run = 7;
200205

201206
// The dispatch payload
202-
google.protobuf.Struct payload = 10;
207+
google.protobuf.Struct payload = 8;
203208
}

0 commit comments

Comments
 (0)