Skip to content

Commit e6f7db9

Browse files
committed
Use github-check reporter for protolint
Using `github-pr-review` requires elevated write permissions to the repository, just to write a review, which can compromise the security of the repository, by using the `pull_request_target` event which gives the GitHub token write access, or using a custom token which complicates the setup. To simplify things we switch back to `github-check` reporter, which is the repo-config default and doesn't need any write permissions, and failed checks will still be shown in the diff view. We also pin the protolint version to `0.52.0` to avoid any surprises with future versions, also as repo-config does. https://github.com/reviewdog/reviewdog?tab=readme-ov-file#reporter-github-pr-annotations--reportergithub-pr-annotations Signed-off-by: Leandro Lucarella <[email protected]>
1 parent 1cc05ae commit e6f7db9

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/ci.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ jobs:
4747
filter_mode: nofilter
4848
github_token: ${{ secrets.github_token }}
4949
protolint_flags: proto/
50-
reporter: github-pr-review
50+
protolint_version: "0.52.0"
51+
reporter: github-check
5152

5253
nox:
5354
name: Test with nox

0 commit comments

Comments
 (0)