Use Event message from common api #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
Marenz
force-pushed
the
event_from_common
branch
2 times, most recently
from
2039cda to
776ae30
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Event enumeration in the dispatch API to use a common Event message from the shared API instead of maintaining a local duplicate. This change standardizes event handling across Frequenz APIs and reduces code duplication.
- Replaces local Event enum with common Event message from frequenz.api.common.v1alpha8.streaming
- Removes duplicate Event enum definition from StreamMicrogridDispatchesResponse
- Updates imports to include the common streaming event module
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| proto/frequenz/api/dispatch/v1/dispatch.proto | Removes local Event enum and uses common Event message, adds streaming event import |
| RELEASE_NOTES.md | Documents the change to use common Event message |
Marenz
force-pushed
the
event_from_common
branch
2 times, most recently
from
41348cb to
a9334a5
Compare
Signed-off-by: Mathias L. Baumann <[email protected]>
Marenz
force-pushed
the
event_from_common
branch
from
a9334a5 to
ba3f84f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #231