Bidirectional: unify client_id and service_id

This is only used to create the underlying `Broadcast` channel's names,
so instead of using 2 separate strings, just use a plain `name` as with
other channels. Also like with other channels, make the `name` optional
and default to a more readable `id(self)` representation (using `_`
separators).

Signed-off-by: Leandro Lucarella <[email protected]>

Author: llucax

src/frequenz/channels/_bidirectional.py

@@ -112,24 +112,19 @@ def consume(self) -> W:
                     err.__cause__ = this_chan_error
                 raise err
 
-    def __init__(self, *, client_id: str, service_id: str) -> None:
+    def __init__(self, *, name: str | None = None) -> None:
         """Create a `Bidirectional` instance.
 
         Args:
-            client_id: A name for the client, used to name the channels.
-            service_id: A name for the service end of the channels.
+            name: A name for the client, used to name the channels.
         """
-        self._client_id: str = client_id
+        self._name: str = f"{id(self):_}" if name is None else name
         """The name for the client, used to name the channels."""
 
-        self._request_channel: Broadcast[T] = Broadcast(
-            name=f"req_{service_id}_{client_id}"
-        )
+        self._request_channel: Broadcast[T] = Broadcast(name=f"{self._name}:request")
         """The channel to send requests."""
 
-        self._response_channel: Broadcast[U] = Broadcast(
-            name=f"resp_{service_id}_{client_id}"
-        )
+        self._response_channel: Broadcast[U] = Broadcast(name=f"{self._name}:response")
         """The channel to send responses."""
 
         self._client_handle: Bidirectional.Handle[T, U] = Bidirectional.Handle(

tests/test_bidirectional.py

@@ -18,9 +18,7 @@
 
 async def test_request_response() -> None:
     """Ensure bi-directional communication is possible."""
-    req_resp: Bidirectional[int, str] = Bidirectional(
-        client_id="test_client", service_id="test_service"
-    )
+    req_resp: Bidirectional[int, str] = Bidirectional(name="test_service")
 
     async def service(handle: Bidirectional.Handle[str, int]) -> None:
         while True:
@@ -54,9 +52,7 @@ async def service(handle: Bidirectional.Handle[str, int]) -> None:
 
 async def test_sender_error_chaining() -> None:
     """Ensure bi-directional communication is possible."""
-    req_resp: Bidirectional[int, str] = Bidirectional(
-        client_id="test_client", service_id="test_service"
-    )
+    req_resp: Bidirectional[int, str] = Bidirectional(name="test_service")
 
     await req_resp._response_channel.close()  # pylint: disable=protected-access
 
@@ -72,9 +68,7 @@ async def test_sender_error_chaining() -> None:
 
 async def test_consume_error_chaining() -> None:
     """Ensure bi-directional communication is possible."""
-    req_resp: Bidirectional[int, str] = Bidirectional(
-        client_id="test_client", service_id="test_service"
-    )
+    req_resp: Bidirectional[int, str] = Bidirectional(name="test_service")
 
     await req_resp._request_channel.close()  # pylint: disable=protected-access