Use repo-config for linting examples in docstrings

Now repo-config ships support to easily enable the collection and
linting of code examples in docstrings, so we use that instead.

Also make sure that we label the `conftest.py` file properly and we
exclude it from the source distribution.

Signed-off-by: Leandro Lucarella <[email protected]>

Author: llucax

.github/labeler.yml

@@ -13,13 +13,15 @@
   - LICENSE
 
 "part:tests":
+  - "**/conftest.py"
   - "tests/**"
 
 "part:tooling":
   - "**/*.ini"
   - "**/*.toml"
   - "**/*.yaml"
   - "**/*.yml"
+  - "**/conftest.py"
   - ".editorconfig"
   - ".git*"
   - ".git*/**"

MANIFEST.in

@@ -3,6 +3,7 @@ exclude .darglint
 exclude .editorconfig
 exclude noxfile.py
 exclude CODEOWNERS
+exclude src/conftest.py
 recursive-exclude .github *
 recursive-exclude tests *
 recursive-exclude benchmarks *

pyproject.toml

@@ -67,10 +67,8 @@ dev-pytest = [
   "async-solipsism == 0.5",
   "hypothesis == 6.84.2",
   "pytest-asyncio == 0.21.1",
+  "frequenz-repo-config[extra-lint-examples] == 0.5.2",
   "pytest-mock == 3.11.1",
-  # For checking docs examples
-  "sybil == 5.0.3",
-  "pylint == 2.17.5",
 ]
 dev = [
   "frequenz-channels[dev-mkdocs,dev-docstrings,dev-formatting,dev-mkdocs,dev-mypy,dev-noxfile,dev-pylint,dev-pytest]",
@@ -110,7 +108,7 @@ disable = [
 ]
 
 [tool.pytest.ini_options]
-testpaths = ["tests", "src"] # src for docs examples
+testpaths = ["tests", "src"]
 asyncio_mode = "auto"
 required_plugins = ["pytest-asyncio", "pytest-mock"]
 markers = [

src/conftest.py

@@ -1,214 +1,13 @@
 # License: MIT
 # Copyright © 2023 Frequenz Energy-as-a-Service GmbH
 
-"""Pytest plugin to validate docstring code examples.
+"""Validate docstring code examples.
 
-Code examples are often wrapped in triple backticks (```) within our docstrings.
+Code examples are often wrapped in triple backticks (```) within docstrings.
 This plugin extracts these code examples and validates them using pylint.
 """
 
+from frequenz.repo.config.pytest import examples
+from sybil import Sybil
 
-import ast
-import os
-import subprocess
-from pathlib import Path
-
-from sybil import Example, Sybil
-from sybil.evaluators.python import pad
-from sybil.parsers.abstract.lexers import textwrap
-from sybil.parsers.myst import CodeBlockParser
-
-PYLINT_DISABLE_COMMENT = (
-    "# pylint: {}=unused-import,wildcard-import,unused-wildcard-import"
-)
-
-FORMAT_STRING = """
-# Generated auto-imports for code example
-{disable_pylint}
-{imports}
-{enable_pylint}
-
-{code}"""
-
-
-def get_import_statements(code: str) -> list[str]:
-    """Get all import statements from a given code string.
-
-    Args:
-        code: The code to extract import statements from.
-
-    Returns:
-        A list of import statements.
-    """
-    tree = ast.parse(code)
-    import_statements: list[str] = []
-
-    for node in ast.walk(tree):
-        if isinstance(node, (ast.Import, ast.ImportFrom)):
-            import_statement = ast.get_source_segment(code, node)
-            assert import_statement is not None
-            import_statements.append(import_statement)
-
-    return import_statements
-
-
-def path_to_import_statement(path: Path) -> str:
-    """Convert a path to a Python file to an import statement.
-
-    Args:
-        path: The path to convert.
-
-    Returns:
-        The import statement.
-
-    Raises:
-        ValueError: If the path does not point to a Python file.
-    """
-    # Make the path relative to the present working directory
-    if path.is_absolute():
-        path = path.relative_to(Path.cwd())
-
-    # Check if the path is a Python file
-    if path.suffix != ".py":
-        raise ValueError("Path must point to a Python file (.py)")
-
-    # Remove 'src' prefix if present
-    parts = path.parts
-    if parts[0] == "src":
-        parts = parts[1:]
-
-    # Remove the '.py' extension and join parts with '.'
-    module_path = ".".join(parts)[:-3]
-
-    # Create the import statement
-    import_statement = f"from {module_path} import *"
-    return import_statement
-
-
-# We need to add the type ignore comment here because the Sybil library does not
-# have type annotations.
-class CustomPythonCodeBlockParser(CodeBlockParser):  # type: ignore[misc]
-    """Code block parser that validates extracted code examples using pylint.
-
-    This parser is a modified version of the default Python code block parser
-    from the Sybil library.
-    It uses pylint to validate the extracted code examples.
-
-    All code examples are preceded by the original file's import statements as
-    well as an wildcard import of the file itself.
-    This allows us to use the code examples as if they were part of the original
-    file.
-
-    Additionally, the code example is padded with empty lines to make sure the
-    line numbers are correct.
-
-    Pylint warnings which are unimportant for code examples are disabled.
-    """
-
-    def __init__(self) -> None:
-        """Initialize the parser."""
-        super().__init__("python")
-
-    def evaluate(self, example: Example) -> None | str:
-        """Validate the extracted code example using pylint.
-
-        Args:
-            example: The extracted code example.
-
-        Returns:
-            None if the code example is valid, otherwise the pylint output.
-        """
-        # Get the import statements for the original file
-        import_header = get_import_statements(example.document.text)
-        # Add a wildcard import of the original file
-        import_header.append(
-            path_to_import_statement(Path(os.path.relpath(example.path)))
-        )
-        imports_code = "\n".join(import_header)
-
-        # Dedent the code example
-        # There is also example.parsed that is already prepared, but it has
-        # empty lines stripped and thus fucks up the line numbers.
-        example_code = textwrap.dedent(
-            example.document.text[example.start : example.end]
-        )
-        # Remove first line (the line with the triple backticks)
-        example_code = example_code[example_code.find("\n") + 1 :]
-
-        example_with_imports = FORMAT_STRING.format(
-            disable_pylint=PYLINT_DISABLE_COMMENT.format("disable"),
-            imports=imports_code,
-            enable_pylint=PYLINT_DISABLE_COMMENT.format("enable"),
-            code=example_code,
-        )
-
-        # Make sure the line numbers are correct
-        source = pad(
-            example_with_imports,
-            example.line - imports_code.count("\n") - FORMAT_STRING.count("\n"),
-        )
-
-        # pylint disable parameters
-        pylint_disable_params = [
-            "missing-module-docstring",
-            "missing-class-docstring",
-            "missing-function-docstring",
-            "reimported",
-            "unused-variable",
-            "no-name-in-module",
-            "await-outside-async",
-        ]
-
-        response = validate_with_pylint(source, example.path, pylint_disable_params)
-
-        if len(response) > 0:
-            response_concats = "\n".join(response)
-            return (
-                f"Pylint validation failed for code example:\n"
-                f"{example_with_imports}\nOutput: {response_concats}"
-            )
-
-        return None
-
-
-def validate_with_pylint(
-    code_example: str, path: str, disable_params: list[str]
-) -> list[str]:
-    """Validate a code example using pylint.
-
-    Args:
-        code_example: The code example to validate.
-        path: The path to the original file.
-        disable_params: The pylint disable parameters.
-
-    Returns:
-        A list of pylint messages.
-    """
-    try:
-        pylint_command = [
-            "pylint",
-            "--disable",
-            ",".join(disable_params),
-            "--from-stdin",
-            path,
-        ]
-
-        subprocess.run(
-            pylint_command,
-            input=code_example,
-            text=True,
-            capture_output=True,
-            check=True,
-        )
-    except subprocess.CalledProcessError as exception:
-        output = exception.output
-        assert isinstance(output, str)
-        return output.splitlines()
-
-    return []
-
-
-pytest_collect_file = Sybil(
-    parsers=[CustomPythonCodeBlockParser()],
-    patterns=["*.py"],
-).pytest()
+pytest_collect_file = Sybil(**examples.get_sybil_arguments()).pytest()