Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 1, 2024

Bumps actions/upload-artifact from 3 to 4.

Release notes

Sourced from actions/upload-artifact's releases.

v4.0.0

What's Changed

The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.

For more information, see the @​actions/artifact documentation.

New Contributors

Full Changelog: actions/upload-artifact@v3...v4.0.0

v3.1.3

What's Changed

Full Changelog: actions/upload-artifact@v3...v3.1.3

v3.1.2

  • Update all @actions/* NPM packages to their latest versions- #374
  • Update all dev dependencies to their most recent versions - #375

v3.1.1

  • Update actions/core package to latest version to remove set-output deprecation warning #351

v3.1.0

What's Changed

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from a team as a code owner January 1, 2024 23:08
@dependabot dependabot bot added part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) type:tech-debt Improves the project without visible changes for users labels Jan 1, 2024
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs investigation and manual updates.

@shsms
Copy link
Contributor

shsms commented Feb 2, 2024

I feel like unless there's critical bugs, we should look into updating gh actions only once a year or something. There's no real reason to update what's already working for us, unless they have some new feature that we want.

@llucax
Copy link
Contributor

llucax commented Feb 2, 2024

I was thinking about the same, monthly updates are definitely better than weekly but still seems like it is too often. I feel like yearly might be too seldom, specially because many updates (I would say most of them) work without needing any changes, so I would probably try first bi-yearly and see how that feels.

If we could make those updates spread more over the many repos we have I think it would also help to avoid the "dependabot fatigue", specially with breaking updates that need investigation If we have it first in one repo, and only get notified in the others after there was some chance that someone looked into it and we know how to upgrade, it can feel less exhausting than just getting many updates that we need we are not going to do anything about for some time.

@llucax
Copy link
Contributor

llucax commented Feb 2, 2024

There's no real reason to update what's already working for us, unless they have some new feature that we want.

BTW, for me the main reason to update is because the "old" actions might get out of support and maybe there are some security bugs that will not get fixed in the old version. This is why at least to me it is important not to lag too behind the latest versions, even if stuff seems to be working for us with the old version.

@llucax
Copy link
Contributor

llucax commented Feb 2, 2024

@Marenz
Copy link
Contributor

Marenz commented Feb 5, 2024

bi-yearly

Or maybe every three months?
But this might not be the best place to discuss this as it will get in all the dependabot updates :D

@llucax
Copy link
Contributor

llucax commented Mar 4, 2024

OK, this doesn't need any changes, just do this and #260 at the same time.

dependabot bot added 2 commits March 4, 2024 15:47
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@llucax llucax force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from 084f27a to a395eb5 Compare March 4, 2024 14:47
@llucax llucax enabled auto-merge March 4, 2024 14:47
@llucax llucax self-assigned this Mar 4, 2024
@llucax llucax added this to the v1.0.0 milestone Mar 4, 2024
@llucax llucax disabled auto-merge March 4, 2024 14:50
@llucax
Copy link
Contributor

llucax commented Mar 4, 2024

Force-merging as this was updated in many other repos and it works fine.

@llucax llucax merged commit 8965997 into v1.x.x Mar 4, 2024
@llucax llucax deleted the dependabot/github_actions/actions/upload-artifact-4 branch March 4, 2024 14:50
@llucax llucax modified the milestones: v1.0.0, v1.0.0-rc.1 Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) type:tech-debt Improves the project without visible changes for users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants