Rename close() to aclose() in Broadcast and Anycast
#408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
This is done to follow Python's convention. With this change now channels can be used with the `aclosing()` context manager for example. The name `close()` is still available for backwards compatibility, but deprecated. Signed-off-by: Leandro Lucarella <[email protected]>
|
Wait, haven't we spoken about this many times already? The |
|
Maybe we change the implementation to wait until the receivers are drained? Alternatively, create a task that would trigger the condition variable, and make |
|
Moving the discussion to the issue (in case we close this PR in favor of another approach, so the discussion is preserved until the issue is fixed): |
shsms
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to follow Python's convention. With this change now channels can be used with the
aclosing()context manager for example.The name
close()is still available for backwards compatibility, but deprecated.Fixes #379.