Use asyncio.Event instead of asyncio.Future in NopReceiver #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It works the same but is less low-level-ish. Signed-off-by: Elzbieta Kotulska <[email protected]>
ela-kotulska-frequenz
added
type:tech-debt
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the use of an asyncio.Future with an asyncio.Event in the NopReceiver implementation to simplify the code.
- Replaces _ready_future with _close_event.
- Updates the ready(), consume(), and close() methods accordingly.
Comments suppressed due to low confidence (1)
src/frequenz/channels/experimental/_nop_receiver.py:32
- The ready() method now always returns False after waiting on the event, which might be non-intuitive. Consider adding a docstring note to clarify that this behavior is intentional in a no-operation receiver.
if self._close_event.is_set():
|
I was worried |
llucax
approved these changes
Jun 18, 2025
I thought they are just a simple wrapper over a future, but apparently they are more complicated because they support multiple waiters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works the same but is less low-level-ish.