select: Don't try selecting on a closed event loop #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathias L. Baumann <[email protected]>
github-actions
bot
added
the
part:synchronization
There was a problem hiding this comment.
Pull Request Overview
This PR prevents the select operation from running on a closed asyncio event loop by checking the event loop's state and raising an appropriate error.
- Adds a check in the select() function to confirm that the event loop is open before proceeding.
- Raises a SelectError when the event loop is closed, ensuring proper error handling.
| receivers_map: dict[str, Receiver[Any]] = {str(hash(r)): r for r in receivers} | ||
| pending: set[asyncio.Task[bool]] = set() | ||
|
|
||
| if asyncio.get_event_loop().is_closed(): |
There was a problem hiding this comment.
[nitpick] Consider using 'asyncio.get_running_loop()' instead of 'asyncio.get_event_loop()' for improved clarity and compatibility with newer Python versions where a running loop is expected.
Suggested change
| if asyncio.get_event_loop().is_closed(): | |
| if asyncio.get_running_loop().is_closed(): |
Marenz
added
the
cmd:skip-release-notes
florian-wagner-frequenz
approved these changes
Jun 19, 2025
|
closing, I don't think it actually helps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we don't try to clean up any tasks (after the eventloop has ended) as we don't even try to create a task and don't enter the
try/finallyblock if there is no event loop at all.