From a15045d439aaf857a77f183e4f7882cb4190f027 Mon Sep 17 00:00:00 2001 From: Sahas Subramanian Date: Thu, 6 Mar 2025 10:07:50 +0100 Subject: [PATCH] Log when stopping `GrpcStreamBroadcaster` instances There's already a similar log message when starting to stream. Signed-off-by: Sahas Subramanian --- src/frequenz/client/base/streaming.py | 1 + tests/streaming/test_grpc_stream_broadcaster.py | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/src/frequenz/client/base/streaming.py b/src/frequenz/client/base/streaming.py index a6134d8..a97b931 100644 --- a/src/frequenz/client/base/streaming.py +++ b/src/frequenz/client/base/streaming.py @@ -88,6 +88,7 @@ def is_running(self) -> bool: async def stop(self) -> None: """Stop the streaming helper.""" + _logger.info("%s: stopping the stream", self._stream_name) if self._task.done(): return self._task.cancel() diff --git a/tests/streaming/test_grpc_stream_broadcaster.py b/tests/streaming/test_grpc_stream_broadcaster.py index e214606..87001a9 100644 --- a/tests/streaming/test_grpc_stream_broadcaster.py +++ b/tests/streaming/test_grpc_stream_broadcaster.py @@ -218,6 +218,11 @@ async def test_streaming_error( # pylint: disable=too-many-arguments '\tdebug_error_string = "mock debug_error_string"\n' ">.", ), + ( + "frequenz.client.base.streaming", + logging.INFO, + "test_helper: stopping the stream", + ), ]