Skip to content

Commit 5837409

Browse files
committed
Fix PaginationParams attributes types
The `page_size` and `page_token` attributes of the `PaginationParams` class are not optional, so they should not be declared as `int | None`. Signed-off-by: Leandro Lucarella <[email protected]>
1 parent 47f66a5 commit 5837409

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

RELEASE_NOTES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
## Upgrading
88

9-
<!-- Here goes notes on how to upgrade from previous versions, including deprecations and what they should be replaced with -->
9+
* The `page_size` and `page_token` attributes of the `PaginationParams` class are not optional anymore, as they aren't either at the protobuf level.
1010

1111
## New Features
1212

src/frequenz/client/common/pagination/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@
1919
class Params:
2020
"""Parameters for paginating list requests."""
2121

22-
page_size: int | None = None
22+
page_size: int
2323
"""The maximum number of results to be returned per request."""
2424

25-
page_token: str | None = None
25+
page_token: str
2626
"""The token identifying a specific page of the list results."""
2727

2828
@classmethod

0 commit comments

Comments
 (0)