Skip to content

Migrate to frequenz-floss dependabot-auto-approve action #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v0.x.x
Choose a base branch
from
Open

Migrate to frequenz-floss dependabot-auto-approve action #126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f691b07
Add Dependabot auto-merge workflow
Marenz Oct 20, 2025
cf2cbc0
Migrate to frequenz-floss dependabot-auto-approve action
Marenz Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/auto-dependabot.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Dependabot Auto Manage
on: pull_request
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the 'pull_request' trigger without specifying types means this workflow runs on every PR action (opened, synchronized, reopened, etc.), potentially triggering multiple auto-merge attempts. Consider specifying the trigger type as 'on: pull_request: types: [opened]' or ensuring the action is idempotent for repeated runs.

Suggested change
on: pull_request
on:
pull_request:
types: [opened]

Copilot uses AI. Check for mistakes.

permissions:
contents: write
pull-requests: write

jobs:
dependabot:
runs-on: ubuntu-latest
if: github.actor == 'dependabot[bot]'
steps:
- uses: frequenz-floss/dependabot-auto-approve@3cad5f42e79296505473325ac6636be897c8b8a1 # v1.3.2
with:
dependency-type: 'all'
auto-merge: 'true'
Comment on lines +15 to +16
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-merging all Dependabot PRs without requiring CI checks to pass is risky. The workflow should include a check to ensure CI tests have passed before merging. Consider adding a needs dependency on CI jobs or configuring branch protection rules to require status checks.

Copilot uses AI. Check for mistakes.
merge-method: 'merge'
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The merge method 'merge' creates merge commits, which differs from the typical squash merge pattern often used for dependency updates. Consider using 'squash' to maintain a cleaner git history, or ensure this aligns with the project's merge strategy for Dependabot PRs.

Suggested change
merge-method: 'merge'
merge-method: 'squash'

Copilot uses AI. Check for mistakes.
add-label: 'auto-merged'