Add streaming.Event bindings #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathias L. Baumann <[email protected]>
github-actions
bot
added
part:docs
There was a problem hiding this comment.
Pull Request Overview
This PR adds Python bindings for the streaming.Event enum from the protobuf API v1alpha8. The implementation provides a Python enum wrapper around the protobuf-generated event types to enable type-safe handling of streaming events.
Key Changes:
- Creates Event enum wrapper for streaming event types (UNSPECIFIED, CREATED, UPDATED, DELETED)
- Adds comprehensive test coverage for the enum conversion functionality
- Updates release notes to document the new Event mapping
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/frequenz/client/common/v1alpha8/streaming/__init__.py |
Implements Event enum wrapper with protobuf bindings for streaming event types |
tests/test_streaming.py |
Adds test coverage for Event enum conversion using enum_from_proto utility |
RELEASE_NOTES.md |
Documents the addition of Event message mapping in release notes |
shsms
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.